catalog/lease: fix flake for TestTableCreationPushesTxnsInRecentPast

Previously, TestTableCreationPushesTxnsInRecentPast could flake because
we attempted to increase the uncertainty interval error by adding a
delay on KV RPC calls to make the uncertainty interval larger. This
would work based on the observed timestamp having a variance between
nodes. This wasn't effective, and we could still have intermittent
failures, because the variance was not large enough. To address this,
this patch will increase the maximum offset on the HLC clock itself,
which is used as the base value for computing the uncertainty interval
(see computeIntervalForTxn). With this change, we expect a more
deterministic reproduction of the txn getting pushed because of the
uncertainty interval.

Fixes: #114366

Release note: None

Author: fqazi

pkg/sql/catalog/lease/BUILD.bazel

@@ -88,7 +88,6 @@ go_test(
         "//pkg/jobs/jobspb",
         "//pkg/keys",
         "//pkg/kv",
-        "//pkg/kv/kvclient/kvcoord",
         "//pkg/kv/kvpb",
         "//pkg/kv/kvserver",
         "//pkg/kv/kvserver/kvserverbase",

pkg/sql/catalog/lease/lease_test.go

@@ -28,7 +28,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/jobs/jobspb"
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/kv"
-	"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver"
 	"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvserverbase"
@@ -2028,12 +2027,8 @@ func TestTableCreationPushesTxnsInRecentPast(t *testing.T) {
 	tc := serverutils.StartCluster(t, 3, base.TestClusterArgs{
 		ServerArgs: base.TestServerArgs{
 			Knobs: base.TestingKnobs{
-				KVClient: &kvcoord.ClientTestingKnobs{
-					// Intentionally add latency so that the uncertainty
-					// limit is higher to reduce the risk of this test flaking.
-					LatencyFunc: func(id roachpb.NodeID) (time.Duration, bool) {
-						return time.Millisecond * 100, true
-					},
+				Store: &kvserver.StoreTestingKnobs{
+					MaxOffset: time.Second,
 				},
 			},
 			DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(109385),