🫧 update for SPA mode in c3 templates#8769
Conversation
🦋 Changeset detectedLatest commit: 58335c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-wrangler-8769You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8769/npm-package-wrangler-8769Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-wrangler-8769 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-bindings-extension-8769 -O ./cloudflare-workers-bindings-extension.0.0.0-v1cc02de0c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1cc02de0c.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-create-cloudflare-8769 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-kv-asset-handler-8769miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-miniflare-8769@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-pages-shared-8769@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-unenv-preset-8769@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-vite-plugin-8769@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-vitest-pool-workers-8769@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-editor-shared-8769@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-shared-8769@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workflows-shared-8769Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
jamesopstad
left a comment
There was a problem hiding this comment.
Looks good. I think you also need to update the tsconfig files to point to worker instead of api.
|
ah great spot with the tsconfig, thanks! |
just removes the fallback ASSETS binding use in the worker