Skip to content

🫧 update for SPA mode in c3 templates#8769

Merged
petebacondarwin merged 4 commits into
mainfrom
emily/spa-mode
Apr 4, 2025
Merged

🫧 update for SPA mode in c3 templates#8769
petebacondarwin merged 4 commits into
mainfrom
emily/spa-mode

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

just removes the fallback ASSETS binding use in the worker


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: has existing tests
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: c3
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented currently
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: c3

@emily-shen emily-shen requested a review from a team April 3, 2025 10:37
@emily-shen emily-shen requested a review from a team as a code owner April 3, 2025 10:37
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 58335c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 3, 2025
@workers-devprod workers-devprod added the ci:c3-e2e Run C3 E2E tests on a pull request label Apr 3, 2025
@emily-shen emily-shen requested a review from GregBrimble April 3, 2025 10:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-wrangler-8769

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8769/npm-package-wrangler-8769

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-wrangler-8769 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-bindings-extension-8769 -O ./cloudflare-workers-bindings-extension.0.0.0-v1cc02de0c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1cc02de0c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-create-cloudflare-8769 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-kv-asset-handler-8769

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-miniflare-8769

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-pages-shared-8769

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-unenv-preset-8769

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-vite-plugin-8769

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-vitest-pool-workers-8769

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-editor-shared-8769

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workers-shared-8769

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14242728296/npm-package-cloudflare-workflows-shared-8769

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.7.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.1
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Copy Markdown
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think you also need to update the tsconfig files to point to worker instead of api.

Comment thread packages/create-cloudflare/templates/vue/workers/js/server/index.js
Comment thread packages/create-cloudflare/templates/vue/workers/ts/server/index.ts
@emily-shen
Copy link
Copy Markdown
Contributor Author

ah great spot with the tsconfig, thanks!

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 3, 2025
@petebacondarwin petebacondarwin merged commit efda570 into main Apr 4, 2025
@petebacondarwin petebacondarwin deleted the emily/spa-mode branch April 4, 2025 09:30
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 4, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:c3-e2e Run C3 E2E tests on a pull request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants