Skip to content

🫧 update for SPA mode in c3 templates #8769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 4 commits into from
Apr 4, 2025
Merged

🫧 update for SPA mode in c3 templates #8769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1395a7
remove unnecessary bits for spa mode
emily-shen Apr 3, 2025
7f30df3
changeset
emily-shen Apr 3, 2025
81f889e
pr feedback
emily-shen Apr 3, 2025
58335c5
remove unnecessary env
emily-shen Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/shiny-facts-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"create-cloudflare": patch
---

remove unnecessary ASSETS binding call in SPA templates

With SPA mode now enabled by default for compat dates since 2025-04-01, the Workers in the React and Vue templates no longer need this fallback ASSETS binding.
2 changes: 1 addition & 1 deletion packages/create-cloudflare/templates/react/workers/js/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function App() {
Name from API is: {name}
</button>
<p>
Edit <code>api/index.js</code> to change the name
Edit <code>worker/index.js</code> to change the name
</p>
</div>
<p className='read-the-docs'>
Expand Down
2 changes: 1 addition & 1 deletion ...e/templates/react/workers/js/api/index.js → ...emplates/react/workers/js/worker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ export default {
});
}

Comment thread
emily-shen marked this conversation as resolved.
return env.ASSETS.fetch(request);
return new Response(null, { status: 404 });
},
}
4 changes: 2 additions & 2 deletions packages/create-cloudflare/templates/react/workers/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "<TBD>",
"main": "api/index.js",
"main": "worker/index.js",
"compatibility_date": "<TBD>",
"assets": { "not_found_handling": "single-page-application", "binding": "ASSETS" },
"assets": { "not_found_handling": "single-page-application" },
"observability": {
"enabled": true
}
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/templates/react/workers/ts/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function App() {
Name from API is: {name}
</button>
<p>
Edit <code>api/index.ts</code> to change the name
Edit <code>worker/index.ts</code> to change the name
</p>
</div>
<p className='read-the-docs'>
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/templates/react/workers/ts/tsconfig.worker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"tsBuildInfoFile": "./node_modules/.tmp/tsconfig.worker.tsbuildinfo",
"types": ["@cloudflare/workers-types/2023-07-01", "./worker-configuration.d.ts", "vite/client"],
},
"include": ["api"],
"include": ["worker"],
}
5 changes: 2 additions & 3 deletions ...e/templates/react/workers/ts/api/index.ts → ...emplates/react/workers/ts/worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
export default {
fetch(request, env) {
fetch(request) {
const url = new URL(request.url);

if (url.pathname.startsWith("/api/")) {
return Response.json({
name: "Cloudflare",
});
}
Comment thread
emily-shen marked this conversation as resolved.

return env.ASSETS.fetch(request);
return new Response(null, { status: 404 });
},
} satisfies ExportedHandler<Env>;
4 changes: 2 additions & 2 deletions packages/create-cloudflare/templates/react/workers/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"name": "<TBD>",
"main": "api/index.ts",
"main": "worker/index.ts",
"compatibility_date": "<TBD>",
"assets": { "not_found_handling": "single-page-application", "binding": "ASSETS" },
"assets": { "not_found_handling": "single-page-application" },
"observability": {
"enabled": true
}
Expand Down
4 changes: 2 additions & 2 deletions packages/create-cloudflare/templates/vue/workers/js/server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export default {
fetch(request, env) {
fetch(request) {
const url = new URL(request.url);

if (url.pathname.startsWith("/api/")) {
Expand All @@ -8,6 +8,6 @@ export default {
});
}

Comment thread
emily-shen marked this conversation as resolved.
return env.ASSETS.fetch(request);
return new Response(null, { status: 404 });
},
};
1 change: 0 additions & 1 deletion packages/create-cloudflare/templates/vue/workers/js/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"main": "server/index.ts",
"assets": {
"not_found_handling": "single-page-application",
"binding": "ASSETS"
},
"observability": {
"enabled": true
Expand Down
5 changes: 2 additions & 3 deletions packages/create-cloudflare/templates/vue/workers/ts/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
export default {
fetch(request, env) {
fetch(request) {
const url = new URL(request.url);

if (url.pathname.startsWith("/api/")) {
return Response.json({
name: "Cloudflare",
});
}
Comment thread
emily-shen marked this conversation as resolved.

return env.ASSETS.fetch(request);
return new Response(null, { status: 404 });
},
} satisfies ExportedHandler<Env>;
1 change: 0 additions & 1 deletion packages/create-cloudflare/templates/vue/workers/ts/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"main": "server/index.ts",
"assets": {
"not_found_handling": "single-page-application",
"binding": "ASSETS"
},
"observability": {
"enabled": true
Expand Down