Skip to content

add hint when no permission to show membership info#8341

Merged
petebacondarwin merged 2 commits into
cloudflare:mainfrom
kotkoroid:main
Apr 4, 2025
Merged

add hint when no permission to show membership info#8341
petebacondarwin merged 2 commits into
cloudflare:mainfrom
kotkoroid:main

Conversation

@kotkoroid
Copy link
Copy Markdown
Contributor

@kotkoroid kotkoroid commented Mar 4, 2025

This pull request adds a hint to let users know that specific API token permissions might not be granted when Wrangler can't retrieve membership roles. This is similar to the behavior in a case where Wrangler is unable to fetch a user's email.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: The change is adding a hint to the localization.
  • Wrangler V3 Backport

@kotkoroid kotkoroid requested a review from a team as a code owner March 4, 2025 12:22
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 678a77b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-wrangler-8341

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8341/npm-package-wrangler-8341

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-wrangler-8341 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-workers-bindings-extension-8341 -O ./cloudflare-workers-bindings-extension.0.0.0-v51380da42.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v51380da42.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-create-cloudflare-8341 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-kv-asset-handler-8341

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-miniflare-8341

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-pages-shared-8341

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-unenv-preset-8341

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-vite-plugin-8341

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-vitest-pool-workers-8341

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-workers-editor-shared-8341

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-workers-shared-8341

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259983730/npm-package-cloudflare-workflows-shared-8341

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.7.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.2
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 2, 2025
@petebacondarwin petebacondarwin self-assigned this Apr 4, 2025
@petebacondarwin petebacondarwin changed the title feat: add hint when no permission to show membership info add hint when no permission to show membership info Apr 4, 2025
@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin merged commit 196f51d into cloudflare:main Apr 4, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 4, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Apr 4, 2025
@holopin-bot
Copy link
Copy Markdown

holopin-bot Bot commented Apr 4, 2025

Congratulations @kotkoroid, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm92ndsrx22960cjomgngtn26

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Apr 4, 2025
edmundhung pushed a commit that referenced this pull request Apr 10, 2025
… (#8783)

* feat: add hint when no permission to show membership info

* chore: add changeset

---------

Co-authored-by: kotkoroid <git@kotkoroid.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants