Skip to content

add hint when no permission to show membership info #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 2 commits into from
Apr 4, 2025
Merged

add hint when no permission to show membership info #8341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a581e
feat: add hint when no permission to show membership info
kotkoroid Mar 4, 2025
678a77b
chore: add changeset
kotkoroid Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/sharp-bottles-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

Improve error message when request to obtain membership info fails

Wrangler now informs user that specific permission might be not granted when fails to obtain membership info. The same information is provided when Wrangler is unable to fetch user's email.
2 changes: 1 addition & 1 deletion packages/wrangler/src/__tests__/whoami.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ describe("whoami", () => {
└───────────────┴────────────┘
🔓 Token Permissions: If scopes are missing, you may need to logout and re-login.
Scope (Access)
🎢 Unable to get membership roles. Make sure you have permissions to read the account."
🎢 Unable to get membership roles. Make sure you have permissions to read the account. Are you missing the \`User->Memberships->Read\` permission?"
`);
});
});
2 changes: 1 addition & 1 deletion packages/wrangler/src/user/whoami.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ async function printMembershipInfo(user: UserInfo, accountFilter?: string) {
} catch (e) {
if (isAuthenticationError(e)) {
logger.log(
`🎢 Unable to get membership roles. Make sure you have permissions to read the account.`
`🎢 Unable to get membership roles. Make sure you have permissions to read the account. Are you missing the \`User->Memberships->Read\` permission?`
);
return;
} else {
Expand Down