--minify/config.minify for scripts
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobMGEvans
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: 0cfcd36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JacobMGEvans
force-pushed
the
minify-script
branch
2 times, most recently
from
94fd7da to
d56c43d
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2177266299/npm-package-wrangler-811You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/811/npm-package-wrangler-811Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2177266299/npm-package-wrangler-811 dev path/to/script.js |
JacobMGEvans
force-pushed
the
minify-script
branch
2 times, most recently
from
f73533a to
14b601c
Compare
packages/wrangler/src/index.tsx
Outdated
Comment on lines
1238
to
1241
| }) | ||
| .option("minify", { | ||
| describe: "Utilize ESBuild minification on script", | ||
| type: "boolean", |
There was a problem hiding this comment.
Suggested change
| }) | |
| .option("minify", { | |
| describe: "Utilize ESBuild minification on script", | |
| type: "boolean", |
no need to have this for preview
There was a problem hiding this comment.
Doesn't preview just use remote Dev? If we don't have parity with Dev I think it would make more sense to just have it deprecated and give the user a message for the Dev command
There was a problem hiding this comment.
That's what we currently do, but we don't want to introduce any new flags for this command (we already don't have all the flags from dev)
JacobMGEvans
force-pushed
the
minify-script
branch
from
14b601c to
6f99186
Compare
JacobMGEvans
commented
Apr 16, 2022
JacobMGEvans
force-pushed
the
minify-script
branch
from
b832338 to
780c985
Compare
JacobMGEvans
force-pushed
the
minify-script
branch
from
e94e707 to
893f200
Compare
…ded to specific environments or inherited from top-level and flags --minify which will minify script for publish and remote Dev. Benefits: - The script minification will allow for more code to the edge while not reaching the 1MB limit. - Obfuscation of code in script. resolves #785
…ded to specific environments or inherited from top-level and flags --minify which will minify script for publish and remote Dev. Benefits: - The script minification will allow for more code to the edge while not reaching the 1MB limit. - Obfuscation of code in script. resolves #785
This was bothering me, so just a quick mechanical cleanup. In all the types we define, putting `| undefined` at the end instead of the beginning to be consistent.
JacobMGEvans
force-pushed
the
minify-script
branch
2 times, most recently
from
f68c0ea to
5e2867a
Compare
packages/wrangler/src/index.tsx
Outdated
| @@ -732,6 +732,10 @@ export async function main(argv: string[]): Promise<void> { | |||
| .option("experimental-enable-local-persistence", { | |||
| describe: "Enable persistence for this session (only for local mode)", | |||
| type: "boolean", | |||
| }) | |||
| .option("minify", { | |||
| describe: "minify the script", | |||
There was a problem hiding this comment.
Suggested change
| describe: "minify the script", | |
| describe: "Minify the script", |
…ded to specific environments or inherited from top-level and flags --minify which will minify script for publish and remote Dev. Benefits: - The script minification will allow for more code to the edge while not reaching the 1MB limit. - Obfuscation of code in script. resolves #785
JacobMGEvans
force-pushed
the
minify-script
branch
from
5e2867a to
0cfcd36
Compare
threepointone
changed the title
--minify/config.minify for scripts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added
minifyas a configuration option and a cli arg, which will minify code fordevandpublishresolves #785