Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trailing | undefined in types. #816

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

threepointone
Copy link
Contributor

This was bothering me, so just a quick mechanical cleanup. In all the types we define, putting | undefined at the end instead of the beginning to be consistent.


No changeset here, no functional changes.

This was bothering me, so just a quick mechanical cleanup. In all the types we define, putting `| undefined` at the end instead of the beginning to be consistent.
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2022

⚠️ No Changeset found

Latest commit: 0964b55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2177037344/npm-package-wrangler-816

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/816/npm-package-wrangler-816

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2177037344/npm-package-wrangler-816 dev path/to/script.js

@threepointone
Copy link
Contributor Author

@threepointone
Copy link
Contributor Author

Landing this because it's safe and and it's the weekend and I don't want folks to be rebasing later.

@threepointone threepointone merged commit d2f5ebb into main Apr 16, 2022
@threepointone threepointone deleted the chore-trailing-undefined-type branch April 16, 2022 14:35
JacobMGEvans pushed a commit that referenced this pull request Apr 16, 2022
This was bothering me, so just a quick mechanical cleanup. In all the types we define, putting `| undefined` at the end instead of the beginning to be consistent.
JacobMGEvans pushed a commit that referenced this pull request Apr 16, 2022
This was bothering me, so just a quick mechanical cleanup. In all the types we define, putting `| undefined` at the end instead of the beginning to be consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant