Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperdrive dev remote fix #7783

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

mtlemilio
Copy link
Contributor

@mtlemilio mtlemilio commented Jan 15, 2025

Fixes SQC-349.

Original PR: #7485

This PR accomplishes the same thing but with amendments from #7536 that solve the issues with the e2e tests.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Does not alter the API surface of the Hyperdrive commands.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: a9e5d3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-wrangler-7783

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7783/npm-package-wrangler-7783

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-wrangler-7783 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-workers-bindings-extension-7783 -O ./cloudflare-workers-bindings-extension.0.0.0-v3003dd128.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3003dd128.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-create-cloudflare-7783 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-kv-asset-handler-7783

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-miniflare-7783

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-pages-shared-7783

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-unenv-preset-7783

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-vite-plugin-7783

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-vitest-pool-workers-7783

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-workers-editor-shared-7783

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-workers-shared-7783

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12891795783/npm-package-cloudflare-workflows-shared-7783

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mtlemilio mtlemilio force-pushed the hyperdrive-dev-remote-fix branch 2 times, most recently from ff5ca08 to 43ba4e3 Compare January 16, 2025 21:12
@mtlemilio mtlemilio marked this pull request as ready for review January 16, 2025 21:13
@mtlemilio mtlemilio requested a review from a team as a code owner January 16, 2025 21:13
@mtlemilio mtlemilio force-pushed the hyperdrive-dev-remote-fix branch from 03cdc34 to a9e5d3d Compare January 21, 2025 16:50
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@CarmenPopoviciu CarmenPopoviciu merged commit a2f695b into cloudflare:main Jan 22, 2025
29 checks passed
penalosa added a commit that referenced this pull request Jan 22, 2025
penalosa added a commit that referenced this pull request Jan 22, 2025
* Revert "Hyperdrive dev remote fix (#7783)"

This reverts commit a2f695b.

* Create silver-pillows-listen.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants