Skip to content

Don't require Hyperdrive local connection string when using wrangler dev --remote #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

mtlemilio
Copy link
Contributor

@mtlemilio mtlemilio commented Dec 6, 2024

Fixes SQC-349.

This is a small fix that addresses an issue customers have been facing, when trying to use wrangler dev --remote we are throwing errors because the local connection string is not set in the Wrangler file or the environment, when it shouldn't be necessary.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This does not change the publicly documented behaviour of Hyperdrive with Wrangler.

@mtlemilio mtlemilio requested a review from a team as a code owner December 6, 2024 19:55
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 63d6953

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-wrangler-7485

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7485/npm-package-wrangler-7485

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-wrangler-7485 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-create-cloudflare-7485 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-kv-asset-handler-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-miniflare-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-pages-shared-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-vitest-pool-workers-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-workers-editor-shared-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-workers-shared-7485
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12244718151/npm-package-cloudflare-workflows-shared-7485

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@mtlemilio mtlemilio force-pushed the hyperdrive-dev-remote-fix branch from 4024081 to 63d6953 Compare December 9, 2024 21:34
@CarmenPopoviciu CarmenPopoviciu merged commit a98dfa0 into cloudflare:main Dec 12, 2024
26 checks passed
penalosa pushed a commit that referenced this pull request Jan 10, 2025
…dev --remote (#7485)

* Don't require Hyperdrive local connection string when using wrangler dev --remote

* Add changeset

* Fix style issues

* fix type issue
@mtlemilio mtlemilio mentioned this pull request Jan 15, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants