Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Pipelines to use name instead of id #7134

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

cmackenzie1
Copy link
Contributor

@cmackenzie1 cmackenzie1 commented Oct 30, 2024

Fixes PIPE-124.

Replaces PR #7100

Recently, Pipelines switched to binding by pipeline names instead of pipeline IDs. This change formalizes that.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: non e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased product

@cmackenzie1 cmackenzie1 requested a review from a team as a code owner October 30, 2024 17:23
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 16e044a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Oct 30, 2024
@cmackenzie1 cmackenzie1 marked this pull request as draft October 30, 2024 17:25
Copy link
Contributor

github-actions bot commented Oct 30, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-wrangler-7134

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7134/npm-package-wrangler-7134

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-wrangler-7134 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-create-cloudflare-7134 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-kv-asset-handler-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-miniflare-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-pages-shared-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-vitest-pool-workers-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-workers-editor-shared-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-workers-shared-7134
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11618771504/npm-package-cloudflare-workflows-shared-7134

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@cmackenzie1 cmackenzie1 marked this pull request as ready for review October 30, 2024 18:32
@edmundhung edmundhung removed the e2e Run e2e tests on a PR label Oct 31, 2024
@edmundhung
Copy link
Member

Hi @cmackenzie1, can you please add a changeset? I understand this is not released yet with no user impact, but this is required to trigger a release.

Also, if there is a ticket related to this work, please update the description with a link to the ticket too.

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Oct 31, 2024
internal ticket: PIPE-124
@cmackenzie1
Copy link
Contributor Author

Thanks for the feedback @edmundhung ! Added a changeset and referenced the internal ticket.

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edmundhung edmundhung merged commit 3ee1353 into cloudflare:main Nov 1, 2024
18 of 19 checks passed
@workers-devprod workers-devprod mentioned this pull request Nov 1, 2024
@cmackenzie1 cmackenzie1 deleted the cole/pipelines-fix branch November 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants