Skip to content

Commit

Permalink
change references to pipeline id to name
Browse files Browse the repository at this point in the history
internal ticket: PIPE-124
  • Loading branch information
cmackenzie1 committed Oct 31, 2024
1 parent 9394ab5 commit ccf40a2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .changeset/friendly-ears-breathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Change Pipelines to use name instead of ID
2 changes: 0 additions & 2 deletions packages/wrangler/e2e/dev-with-resources.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,6 @@ describe.sequential.each(RUNTIMES)("Bindings: $flags", ({ runtime, flags }) => {
pipeline = "my-pipeline"
`,
"src/index.ts": dedent`
import { Pipeline } from "cloudflare:workers";
export default {
async fetch(request, env, ctx) {
if (env.PIPELINE === undefined) {
Expand Down
6 changes: 3 additions & 3 deletions packages/wrangler/src/__tests__/deploy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11239,7 +11239,7 @@ export default{
pipelines: [
{
binding: "MY_PIPELINE",
pipeline: "0123456789ABCDEF0123456789ABCDEF",
pipeline: "my-pipeline",
},
],
});
Expand All @@ -11250,7 +11250,7 @@ export default{
{
type: "pipelines",
name: "MY_PIPELINE",
id: "0123456789ABCDEF0123456789ABCDEF",
pipeline: "my-pipeline",
},
],
});
Expand All @@ -11261,7 +11261,7 @@ export default{
Worker Startup Time: 100 ms
Your worker has access to the following bindings:
- Pipelines:
- MY_PIPELINE: 0123456789ABCDEF0123456789ABCDEF
- MY_PIPELINE: my-pipeline
Uploaded test-name (TIMINGS)
Deployed test-name triggers (TIMINGS)
https://test-name.test-sub-domain.workers.dev
Expand Down
6 changes: 3 additions & 3 deletions packages/wrangler/src/__tests__/init.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2445,7 +2445,7 @@ describe("init", () => {
{
type: "pipelines",
name: "PIPELINE_BINDING",
id: "some-id",
pipeline: "some-name",
},
{
type: "mtls_certificate",
Expand Down Expand Up @@ -2670,7 +2670,7 @@ describe("init", () => {
pipelines: [
{
binding: "PIPELINE_BINDING",
pipeline: "some-id",
pipeline: "some-name",
},
],
queues: {
Expand Down Expand Up @@ -3212,7 +3212,7 @@ describe("init", () => {
[[pipelines]]
binding = \\"PIPELINE_BINDING\\"
pipeline = \\"some-id\\"
pipeline = \\"some-name\\"
[[mtls_certificates]]
binding = \\"MTLS_BINDING\\"
Expand Down

0 comments on commit ccf40a2

Please sign in to comment.