-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows commands #7015
Workflows commands #7015
Conversation
🦋 Changeset detectedLatest commit: fd82b95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
197f336
to
80af061
Compare
4bb9f9b
to
40363a0
Compare
40363a0
to
74a8019
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-wrangler-7015 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7015/npm-package-wrangler-7015 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-wrangler-7015 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-create-cloudflare-7015 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-kv-asset-handler-7015 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-miniflare-7015 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-pages-shared-7015 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-vitest-pool-workers-7015 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-workers-editor-shared-7015 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11407867452/npm-package-cloudflare-workers-shared-7015 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - can't wait to see this land. It's fantastic to see defineCommand
in action - it definitely helps to keep things clean and straightforward.
metadata: { | ||
description: | ||
"Delete workflow - when deleting a workflow, it will also delete it's own instances", | ||
owner: "Product: Workflows", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might think about creating a separate owners
config, which would help to keep this consistent over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this in the design but I think the granularity and colocation trump the duplication and especially since it will be infrequently changed
0ebf81a
to
658f82e
Compare
placeholder issue as reminder to add tests: #7056 |
What this PR solves / how to test
Fixes #0000
Implementation for
wrangler workflows ...
commands. Refactored to use the defineCommand util.Not tested right now but is isolated to just those commands – plan is to follow up with automated tests next week.
Author has addressed the following
wrangler workflows *
commands, will add tests in a follow-up PR next week