workers: fix typo #16220
Merged
workers: fix typo #16220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
product:workflows
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11021221 | Triggered | Generic High Entropy Secret | 07faddc | src/content/products/workflows.yaml | View secret |
| 11021221 | Triggered | Generic High Entropy Secret | dae5204 | src/content/products/workflows.yaml | View secret |
| 11021221 | Triggered | Generic High Entropy Secret | cc09b34 | astro.config.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Deploying cloudflare-docs with
|
| Latest commit: |
e858bb1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e1288d3.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://silverlock-workflows-new.cloudflare-docs-7ou.pages.dev |
github-actions
bot
added
size/xl
product:workers
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
github-actions
bot
added
product:1.1.1.1
Oxyjun
reviewed
Oct 24, 2024
Oxyjun
reviewed
Oct 24, 2024
Stops the required CI pipeline from breaking.
Oxyjun
reviewed
Oct 24, 2024
Oxyjun
reviewed
Oct 24, 2024
Oxyjun
reviewed
Oct 24, 2024
Oxyjun
reviewed
Oct 24, 2024
Not fixing it blocks merge.
Oxyjun
approved these changes
Oct 24, 2024
Co-authored-by: Diogo Ferreira <[email protected]> Co-authored-by: Jun Lee <[email protected]>
elithrar
requested review from
penalosa,
petebacondarwin,
dario-piotrowicz,
irvinebroque,
GregBrimble,
a team,
mikenomitch,
WalshyDev and
ToriLindsay
as code owners
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* commit * icon * fix link * rename to workflows-starter * fix limit * mebibyte * events and params * npx -> npm * more * wrangler * cron triggers * more docs * rules of steps * fix * CLI guide * finish CLI starter * update landing page * fix numbering * fix link formatting * fix * sleeping / retrying * trigger * wording * wrap get-started guide * rules of workflows * trigger done * sleep * NonRetryableError * better header for nonretryableerror * npm create cloudflare@latest workflows-starter -- --template 'cloudflare/workflows-starter' * Apply suggestions from code review Co-authored-by: Jun Lee <[email protected]> * @workflows -> @latest * remove output from CLI guide * fix missing link * fix links * workflows: review Co-authored-by: Jun Lee <[email protected]> * Adds Workflows GraphQL examples and docs * Apply suggestions from code review Co-authored-by: Jun Lee <[email protected]> * types * changelog + dates * Apply suggestions from code review Fixing broken CI (required) pipeline by removing duplicated lines. * workflows: Apply suggestions from code review Co-authored-by: Jun Lee <[email protected]> * compat date * remove how-workflows-works for now * finalize types * wrangler version note * Importing Type and MetaInfo component Stops the required CI pipeline from breaking. * Fixing REST API links Not fixing it blocks merge. * Apply suggestions from code review Co-authored-by: Diogo Ferreira <[email protected]> Co-authored-by: Jun Lee <[email protected]> * fix API URL * comment out pause * fix bad class naming * edits * naming steps --------- Co-authored-by: Jun Lee <[email protected]> Co-authored-by: Celso Martinho <[email protected]> Co-authored-by: Diogo Ferreira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Workflow,WorkflowEntrypoint, and type params (cc @sidharthachatterjee once we have the types updated)wrangler workflowscommandsLater: