[wranger] fix: createMetadataObject to use logging levels (#4265)

[magnusdahlstrand]

Relates to #4265.

What this PR solves / how to test:
createMetadataObject previously only received a single logging function set to warn. This PR updates it to receive a full Logger object, and updates it to use the various levels correctly.

Previously messages such as [WARNING] Parsed 2 valid header rules. were output to the console, whereas with this fix they're no longer warnings, and therefore can be muted with --log-level=info.

Additionally, wrangler/src/miniflare-cli/assets.ts was defining its own Logger interface but is now loading the interface from the logger.ts file.

Author has addressed the following:

• Tests
  • Included
  • Not necessary because: Covered by existing tests.
• Changeset (Changeset guidelines)
  • Included
  • Not necessary because:
• Associated docs
  • Issue(s)/PR(s): 🐛 BUG: pages dev output is unnecessarily verbose #4265
  • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

[changeset-bot]

🦋 Changeset detected

Latest commit: c3a2396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cloudflare/pages-shared	Patch
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7697441483/npm-package-wrangler-4819

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4819/npm-package-wrangler-4819

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7697441483/npm-package-wrangler-4819 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7697441483/npm-package-create-cloudflare-4819 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7697441483/npm-package-miniflare-4819

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7697441483/npm-package-cloudflare-pages-shared-4819

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231218.4
workerd	1.20231218.0	1.20231218.0
workerd --version	1.20231218.0	2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3e410c) 71.47% compared to head (c3a2396) 70.71%.
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
- Coverage   71.47%   70.71%   -0.76%     
==========================================
  Files         288      291       +3     
  Lines       14831    15164     +333     
  Branches     3729     3859     +130     
==========================================
+ Hits        10600    10723     +123     
- Misses       4231     4441     +210     

see 19 files with indirect coverage changes

[petebacondarwin]

LGTM - can you fix up the changeset to be more clear what is changing?

[magnusdahlstrand]

Thanks @petebacondarwin for your input on the changeset, let me know if anything else is needed from my side!

[lrapoport-cf]

can someone from @cloudflare/pages please review this as well? cc @GregBrimble @jahands @WalshyDev @jrf0110 @CarmenPopoviciu

[GregBrimble]

LGTM!