Skip to content

Conversation

@RamIdeas
Copy link
Contributor

This unreverts the commit reverted in #4493

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@RamIdeas RamIdeas requested a review from a team November 22, 2023 19:06
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 8b15bd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamIdeas RamIdeas changed the title Revert "Revert "C3: Change default project type to hello world worker… Unrevert commit reverted in #4493 Nov 22, 2023
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961693152/npm-package-wrangler-4494

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6961693152/npm-package-wrangler-4494

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961693152/npm-package-wrangler-4494 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961693152/npm-package-miniflare-4494
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6961693152/npm-package-cloudflare-pages-shared-4494

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.17.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #4494 (8b15bd0) into main (d365cba) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4494   +/-   ##
=======================================
  Coverage   75.25%   75.26%           
=======================================
  Files         226      226           
  Lines       12570    12570           
  Branches     3261     3261           
=======================================
+ Hits         9460     9461    +1     
+ Misses       3110     3109    -1     

see 4 files with indirect coverage changes

@RamIdeas RamIdeas merged commit 9bea4e3 into main Nov 22, 2023
@RamIdeas RamIdeas deleted the unrevert-c3-commit branch November 22, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants