Skip to content

Conversation

@jculvey
Copy link
Contributor

@jculvey jculvey commented Nov 14, 2023

What this PR solves / how to test:
In a previous change we changed the default project type from hello-world to webFramework. We received some feedback from the community that this makes the use case of creating a vanilla worker harder, and that it breaks examples/tutorials in our docs where we suggest using --accept-defaults for creating workers.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team November 14, 2023 21:02
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: a92a049

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-wrangler-4442

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6948761055/npm-package-wrangler-4442

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-wrangler-4442 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-miniflare-4442
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-cloudflare-pages-shared-4442

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.16.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.0
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #4442 (a92a049) into main (fe1e6d8) will decrease coverage by 0.01%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4442      +/-   ##
==========================================
- Coverage   75.27%   75.27%   -0.01%     
==========================================
  Files         226      226              
  Lines       12555    12568      +13     
  Branches     3256     3260       +4     
==========================================
+ Hits         9451     9460       +9     
- Misses       3104     3108       +4     

see 11 files with indirect coverage changes

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃 🥳

@jculvey jculvey force-pushed the c3-reorder-hello-world branch from 197ed8e to 689bcd8 Compare November 20, 2023 22:43
@jculvey jculvey merged commit 5f54f72 into main Nov 22, 2023
@jculvey jculvey deleted the c3-reorder-hello-world branch November 22, 2023 14:56
RamIdeas added a commit that referenced this pull request Nov 22, 2023
RamIdeas added a commit that referenced this pull request Nov 22, 2023
RamIdeas added a commit that referenced this pull request Nov 22, 2023
RamIdeas added a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants