-
Notifications
You must be signed in to change notification settings - Fork 1.1k
C3: Change default project type to hello world worker #4442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a92a049 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-wrangler-4442You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6948761055/npm-package-wrangler-4442Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-wrangler-4442 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-miniflare-4442npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6948761055/npm-package-cloudflare-pages-shared-4442Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4442 +/- ##
==========================================
- Coverage 75.27% 75.27% -0.01%
==========================================
Files 226 226
Lines 12555 12568 +13
Branches 3256 3260 +4
==========================================
+ Hits 9451 9460 +9
- Misses 3104 3108 +4 |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃 🥳
197ed8e to
689bcd8
Compare
What this PR solves / how to test:
In a previous change we changed the default project type from
hello-worldtowebFramework. We received some feedback from the community that this makes the use case of creating a vanilla worker harder, and that it breaks examples/tutorials in our docs where we suggest using--accept-defaultsfor creating workers.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.