feat: delete site/assets namespace when a worker is deleted #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
requested review from
rozenmd and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: 4ab7615 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This patch deletes any site/asset kv namespaces associated with a worker when `wrangler delete` is used. It finds the namespace associated with a worker by using the names it would have otherwise used, and deletes it. It also does the same for the preview namespace that's used with `wrangler dev`.
threepointone
force-pushed
the
deletes-site-assets-namespace
branch
from
5e35ed0 to
4ab7615
Compare
|
"First time contributors" pssssh |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3355995707/npm-package-wrangler-2098You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2098/npm-package-wrangler-2098Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3355995707/npm-package-wrangler-2098 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3355995707/npm-package-cloudflare-pages-shared-2098 |
Codecov Report
@@ Coverage Diff @@
## main #2098 +/- ##
==========================================
+ Coverage 73.06% 73.12% +0.05%
==========================================
Files 127 127
Lines 8595 8610 +15
Branches 2263 2264 +1
==========================================
+ Hits 6280 6296 +16
+ Misses 2315 2314 -1
|
rozenmd
approved these changes
Oct 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deletes any site/asset kv namespaces associated with a worker when
wrangler deleteis used. It finds the namespace associated with a worker by using the names it would have otherwise used, and deletes it. It also does the same for the preview namespace that's used withwrangler dev.