-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement wrangler delete
#1065
Comments
Is this a duplicate of #25 ? |
Landed a basic version in #2045. My usecase is pushing a new worker for every PR in my project (named by branch), and deleting it when the PR closes. It works well for now! |
yes, please re: the We're doing same worker-per-PR you describe and we need to delete assets namespace for the same reason. It didn't take long to learn there's a limit of 100 workers and 200 KV namespaces. Once you hit either limit the new deploys (API requests) start failing |
I'll try to send a PR that does site/assets namespace deletion this weekend. Re: the 100/200 limit, my 2c for workers: I wonder if cloudflare could provide a new kind of publish here. We don't need these to be globally distributed, or even particularly long lived. It could use the same infra as Alternately, there's now opportunity to just run workerd on something like fly.io (but making it 'work' with/mock every other cf service would be a pita for site namespaces: really, kv was only a temporary solution for static assets. the pages upload api should mature, and replace kv as the primitive for static assets. |
I got a PR up for deleting sites/assets namespaces #2098 |
@threepointone we good to close this one? |
Yeah. You'll have to revisit it in the future when (if?) service environments become a thing, but this issue should be good to close for now. |
We should be able to delete a Worker from the CLI, potentially include all its environments, and linked Durable Objects and other resources. Probably needs to be interactive, but we could also add a
--force
flag. We'd taken an initial attempt at it for wrangler 1 but it never landed cloudflare/wrangler-legacy#2086The text was updated successfully, but these errors were encountered: