Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement wrangler delete #1065

Closed
threepointone opened this issue May 19, 2022 · 7 comments
Closed

feat: Implement wrangler delete #1065

threepointone opened this issue May 19, 2022 · 7 comments
Labels
chunky Bigger than most enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

We should be able to delete a Worker from the CLI, potentially include all its environments, and linked Durable Objects and other resources. Probably needs to be interactive, but we could also add a --force flag. We'd taken an initial attempt at it for wrangler 1 but it never landed cloudflare/wrangler-legacy#2086

@threepointone threepointone added the enhancement New feature or request label May 19, 2022
@threepointone threepointone moved this to Untriaged in workers-sdk May 19, 2022
@petebacondarwin petebacondarwin moved this from Untriaged to Backlog in workers-sdk May 24, 2022
@threepointone threepointone moved this from Backlog to Selected for development in workers-sdk Jul 1, 2022
@threepointone threepointone added the chunky Bigger than most label Jul 4, 2022
@petebacondarwin
Copy link
Contributor

Is this a duplicate of #25 ?

This was referenced Sep 26, 2022
@threepointone
Copy link
Contributor Author

Landed a basic version in #2045. My usecase is pushing a new worker for every PR in my project (named by branch), and deleting it when the PR closes. It works well for now!

@jfsiii
Copy link

jfsiii commented Oct 18, 2022

yes, please re: the maybe delete sites/assets kv namespace as well? comment in that PR

We're doing same worker-per-PR you describe and we need to delete assets namespace for the same reason.

It didn't take long to learn there's a limit of 100 workers and 200 KV namespaces. Once you hit either limit the new deploys (API requests) start failing

@threepointone
Copy link
Contributor Author

I'll try to send a PR that does site/assets namespace deletion this weekend.

Re: the 100/200 limit, my 2c

for workers: I wonder if cloudflare could provide a new kind of publish here. We don't need these to be globally distributed, or even particularly long lived. It could use the same infra as wrangler dev.

Alternately, there's now opportunity to just run workerd on something like fly.io (but making it 'work' with/mock every other cf service would be a pita

for site namespaces: really, kv was only a temporary solution for static assets. the pages upload api should mature, and replace kv as the primitive for static assets.

@threepointone
Copy link
Contributor Author

I got a PR up for deleting sites/assets namespaces #2098

@rozenmd
Copy link
Contributor

rozenmd commented Dec 29, 2022

@threepointone we good to close this one?

@threepointone
Copy link
Contributor Author

Yeah. You'll have to revisit it in the future when (if?) service environments become a thing, but this issue should be good to close for now.

@github-project-automation github-project-automation bot moved this from Selected for Development to Done in workers-sdk Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chunky Bigger than most enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants