feat: implement a basic wrangler delete
#2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eedf371 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
force-pushed
the
wrangler-delete
branch
from
cd0c62c to
92f410d
Compare
rozenmd
reviewed
Oct 18, 2022
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3275008068/npm-package-wrangler-2045You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2045/npm-package-wrangler-2045Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3275008068/npm-package-wrangler-2045 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3275008068/npm-package-cloudflare-pages-shared-2045 |
threepointone
force-pushed
the
wrangler-delete
branch
from
92f410d to
fc77c35
Compare
Codecov Report
@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
+ Coverage 72.53% 72.64% +0.11%
==========================================
Files 123 124 +1
Lines 8399 8430 +31
Branches 2202 2208 +6
==========================================
+ Hits 6092 6124 +32
+ Misses 2307 2306 -1
|
rozenmd
reviewed
Oct 18, 2022
| // delete | ||
| wrangler.command( | ||
| "delete [script]", | ||
| "🗑 Delete your Worker from Cloudflare.", |
This PR adds a simple (but useful!) implementation for `wrangler delete`. Of note, it'll delete a given service, including all it's bindings. It uses the same api as the dashboard.
threepointone
force-pushed
the
wrangler-delete
branch
from
fc77c35 to
eedf371
Compare
penalosa
reviewed
Oct 18, 2022
| await fetchResult( | ||
| `/accounts/${accountId}/workers/services/${scriptName}`, | ||
| { method: "DELETE" }, | ||
| new URLSearchParams({ force: "true" }) |
There was a problem hiding this comment.
Should the force be added as a CLI option?
There was a problem hiding this comment.
I considered it, but honestly it's the only way that it's actually useful (which is why it's added by default on the dashboard too).
rozenmd
approved these changes
Oct 18, 2022
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple (but useful!) implementation for
wrangler delete. Of note, it'll delete a given service, including all it's bindings. It uses the same api as the dashboard.