fix: secret input trailing spaces

[JacobMGEvans]

Added trimTrailingWhitespace() to secretValue being sent in PUT request
Matching Wrangler legacy behavior with handling inputs

resolves #993

[changeset-bot]

🦋 Changeset detected

Latest commit: a05478f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2346143277/npm-package-wrangler-1044

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1044/npm-package-wrangler-1044

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2346143277/npm-package-wrangler-1044 dev path/to/script.js

[petebacondarwin]

Trimming the secret value would be a breaking change. Currently I can run

$ npx wrangler secret put foo

Then type in the characters " abc ". And these spaces are still available in my Worker.

[petebacondarwin]

I think instead we only want to remove a trailing \n and only when reading from stdin.

[petebacondarwin]

Thanks @JacobMGEvans - just a couple of minor requests before we merge.

[petebacondarwin]

We should try to write these changeset descriptions from the point of view of the changelog reader. So I would describe the external effect rather than the implementation change in the heading. E.g.

fix: trim trailing whitespace from the secrets before uploading

[JacobMGEvans]

Good point. Thanks!

[petebacondarwin]

LGTM!