Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: the value read from stdin should be trimmed #993

Closed
dhcmrlchtdj opened this issue May 13, 2022 · 1 comment · Fixed by #1044 or #1025
Closed

🐛 BUG: the value read from stdin should be trimmed #993

dhcmrlchtdj opened this issue May 13, 2022 · 1 comment · Fixed by #1044 or #1025
Assignees
@JacobMGEvans
Labels
bug Something that isn't working

Comments

@dhcmrlchtdj
Copy link

What version of Wrangler are you using?

2.0.3

What operating system are you using?

linux

Describe the Bug

I use wrangler on github action and set secrets in a non-interactive way
like this

$  echo 'some_value' | wrangler secret put 'TOKEN'

When I update from @cloudflare/wrangler to wrangler2, the TOKEN no longer what I expected.

expected: TOKEN === "some_value"
actual: TOKEN === "some_value\n"

@cloudflare/wrangler will strip all trailing whitespace (code
but wrangler2 return the stdin directly (code
@threepointone threepointone moved this to Must-have in workers-sdk May 13, 2022
@threepointone threepointone added this to the 2.1 milestone May 13, 2022
@threepointone
Copy link
Contributor

Nice catch, we should fix this soon!

@petebacondarwin petebacondarwin modified the milestones: Selected for development, Backlog May 15, 2022
@petebacondarwin petebacondarwin moved this to Backlog in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Backlog milestone May 15, 2022
@petebacondarwin petebacondarwin added bug Something that isn't working and removed type: bug labels May 16, 2022
@petebacondarwin petebacondarwin moved this from Backlog to Selected for development in workers-sdk May 16, 2022
@JacobMGEvans JacobMGEvans self-assigned this May 17, 2022
@JacobMGEvans JacobMGEvans mentioned this issue May 17, 2022
Merged
@threepointone threepointone moved this from Selected for development to In Progress in workers-sdk May 17, 2022
JacobMGEvans added a commit that referenced this issue May 17, 2022
@JacobMGEvans
fix: added trimTrailingWhitespace() to secretValue being sent in PU…
5b79371 
…T request

Matching Wrangler legacy behavior with handling inputs

resolves #993
JacobMGEvans added a commit that referenced this issue May 17, 2022
@JacobMGEvans
fix: added trimTrailingWhitespace() to secretValue being sent in PU…
60d3942 
…T request

Matching Wrangler legacy behavior with handling inputs

resolves #993
JacobMGEvans added a commit that referenced this issue May 18, 2022
@JacobMGEvans
fix: added trimTrailingWhitespace() to secretValue being sent in PU…
368200f 
…T request

Matching Wrangler legacy behavior with handling inputs

resolves #993
JacobMGEvans added a commit that referenced this issue May 18, 2022
@JacobMGEvans
fix: added trimTrailingWhitespace() to secretValue being sent in PU…
a05478f 
…T request

Matching Wrangler legacy behavior with handling inputs

resolves #993
petebacondarwin pushed a commit that referenced this issue May 18, 2022
@JacobMGEvans
fix: added trimTrailingWhitespace() to secretValue being sent in PU…
7a191a2 
…T request (#1044)

Matching Wrangler legacy behavior with handling inputs

resolves #993
Repository owner moved this from In Progress to Done in workers-sdk May 18, 2022
@github-actions github-actions bot mentioned this issue May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
bug Something that isn't working
Projects
None yet
Milestone
No milestone
4 participants
@petebacondarwin @threepointone @dhcmrlchtdj @JacobMGEvans