Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 22, 2024

Example/Demo app showing the usage of this new implementation: https://github.com/dario-piotrowicz/next-on-pages-next-dev-get-bindings-proxy-test-demo


fixes #623

fixes #634 (by shifting the issue to getBindingsProxy: cloudflare/workers-sdk#4793)

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 34fdf51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/next-on-pages Minor
eslint-plugin-next-on-pages Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024

🧪 Prereleases are available for testing 🧪

Details

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7806835531/npm-package-next-on-pages-648

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7806835531/npm-package-eslint-plugin-next-on-pages-648

@dario-piotrowicz dario-piotrowicz force-pushed the use-getBindingsProxy branch 3 times, most recently from b2f8a58 to 0ef1fec Compare January 31, 2024 11:31
@dario-piotrowicz dario-piotrowicz changed the title use getBindingsProxy replace setupDevBindings with setupDevPlatform (and use getBindingsProxy under the hood) Jan 31, 2024
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review February 1, 2024 15:15
@dario-piotrowicz dario-piotrowicz changed the title replace setupDevBindings with setupDevPlatform (and use getBindingsProxy under the hood) add new setupDevPlatform and deprecate setupDevBindings Feb 2, 2024
@dario-piotrowicz dario-piotrowicz merged commit 06de52e into cloudflare:main Feb 6, 2024
@dario-piotrowicz dario-piotrowicz deleted the use-getBindingsProxy branch February 6, 2024 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Ensure ALL supported types are exposed to DevBindingsOptions Chore: use getBindingsProxy in the next-dev sub-module

3 participants