This repository was archived by the owner on Sep 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 166
add new setupDevPlatform and deprecate setupDevBindings
#648
Merged
dario-piotrowicz
merged 12 commits into
cloudflare:main
from
dario-piotrowicz:use-getBindingsProxy
Feb 6, 2024
Merged
add new setupDevPlatform and deprecate setupDevBindings
#648
dario-piotrowicz
merged 12 commits into
cloudflare:main
from
dario-piotrowicz:use-getBindingsProxy
Feb 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 34fdf51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🧪 Prereleases are available for testing 🧪 Details@cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7806835531/npm-package-next-on-pages-648@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7806835531/npm-package-eslint-plugin-next-on-pages-648 |
1f32996 to
869b826
Compare
This was referenced Jan 30, 2024
b2f8a58 to
0ef1fec
Compare
getBindingsProxysetupDevBindings with setupDevPlatform (and use getBindingsProxy under the hood)
This was referenced Feb 1, 2024
87d319b to
0486f38
Compare
james-elicx
reviewed
Feb 1, 2024
setupDevBindings with setupDevPlatform (and use getBindingsProxy under the hood)setupDevPlatform and deprecate setupDevBindings
Merged
6 tasks
jculvey
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example/Demo app showing the usage of this new implementation: https://github.com/dario-piotrowicz/next-on-pages-next-dev-get-bindings-proxy-test-demo
fixes #623
fixes #634 (by shifting the issue to
getBindingsProxy: cloudflare/workers-sdk#4793)