-
Notifications
You must be signed in to change notification settings - Fork 166
docs: update next-dev README to include link to available binding types #633
Conversation
|
|
🧪 Prereleases are available for testing 🧪 Details@cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7507981567/npm-package-next-on-pages-633@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/7507981567/npm-package-eslint-plugin-next-on-pages-633 |
IgorMinar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. the line numbers will likely change over time, but this type needs to be documented in wrangler docs as part of getBindingsProxy anyway we can keep it as is and update the link here then.
|
@admah can you please fix the prettier check failure? |
| ``` | ||
|
|
||
|
|
||
| > View [this file](https://github.com/cloudflare/next-on-pages/blob/main/internal-packages/next-dev/src/index.ts#L31-L60) for a list of available binding types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > View [this file](https://github.com/cloudflare/next-on-pages/blob/main/internal-packages/next-dev/src/index.ts#L31-L60) for a list of available binding types. | |
| > View [these types](https://github.com/cloudflare/next-on-pages/blob/main/internal-packages/next-dev/src/index.ts#L31-L60) for a list of available binding types. |
or something along those lines as user should not care about the whole file no? 🤔
For that reason I always go with permalinks, so that the link itself will always remain valid, wouldn't then something like |
|
I am actually not sure of this change... I think that presenting the bindings in the md file instead of pointing users to a ts file would be a very simple, quick and nicer alternative to this 🤔 (we could also add docs links to the binding types, etc...) Note You can notice that the binding types lack ts-docs, I didn't add them since as Igor mentioned, the logic here should be replaced with @admah if you wouldn't mind I could give that a go? |
|
I'm closing this PR since we're moving away from the I'll make sure to update the next-on-pages docs with all the available bindings 🙂 Or actually I'll just refer to the I hope that works for you @admah 🙂🙏 |
No description provided.