2022 CI + Benchmarking refresh #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
force-pushed
the
movermeyer/python_3_11
branch
from
6f3039d
to
a6bb816
Compare
movermeyer
force-pushed
the
movermeyer/python_3_11
branch
from
3fae481
to
d24bee5
Compare
movermeyer
force-pushed
the
movermeyer/python_3_11
branch
from
d24bee5
to
923c9f3
Compare
movermeyer
commented
Oct 27, 2022
| return results | ||
|
|
||
| def version_sort(versions): |
There was a problem hiding this comment.
Before, it was sorting alphanumerically, resulting in "3.10, 3.11, 3.9..." instead of "3.7...3.11".
thomasst
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Python 3.11 has been released.
Make sure that we're testing against it.
Refresh all the bits of our CI/benchmarking that are stale too.
What approach did you choose and why?
Searched for references to "3.10" and added "3.11".
I also updating the benchmarks to:
datetime.datetime.fromisoformat(Fixes Adddatetime.datetime.fromisoformatto benchmarking #125)mayaandmomentfrom Python 2.7 testingudatetimefor modern Python versions (> 3.9), since they fixed their bug.Since CicleCI isn't going to release Docker image for Python 3.11 under their old a
circleci/pythonnamespace, I migrated our Docker images to use their newcimg/pythonnamespace (Fixes #127) . This didn't support Python 3.4, so I duplicated our existing config to continue supporting 3.4. Deprecating 3.4 support can be considered in a separate issue.I also noted that PyPy 3.9 is out, so I added it to the CI.
What should reviewers focus on?
I intentionally left out the updated benchmarks until I verify that
datetime.fromisoformatreally does cover all of ciso8601's subset. After that, I'll add the new results and contextualize them.(While
datetime.fromisoformatis faster for timestamps without a timezone, our lean timezone implementation means that we are still faster for timestamps with a timezone)It seems that the vast majority of Python users will no longer have a reason to use ciso8601. 🎉🖤
The impact of these changes
Keeping up to date with the world of Python and CircleCI.