Update benchmark numbers #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
force-pushed
the
movermeyer/update_benchmark_numbers
branch
3 times, most recently
from
96f455e
to
3e25eac
Compare
AlecRosenbaum
approved these changes
Nov 27, 2022
movermeyer
force-pushed
the
movermeyer/update_benchmark_numbers
branch
from
3e25eac
to
652378a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Now that #126 and #130 are merged, and
ciso8601is still on top, it's time to brag a bit by updating the benchmark numbers. 🎉What approach did you choose and why?
What should reviewers focus on?
🤷 You can see the rendered version here.
If #138 is merged first, I'll recreate this PR with that library included too.
The impact of these changes
Fixes #66