-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,localizations,types): Add sign in or up subtitle localizations #4988
Conversation
🦋 Changeset detectedLatest commit: 1f2efb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sx={{ | ||
'&:empty': { | ||
display: 'none', | ||
}, | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the sign in start subtitle is undefined, and we use the empty selector to ensure the element does not take up any space within the dom. This is to enable folks to see that there is a localization option available for subtitle when viewing source in the dom. Then they can add the localization and it will show for them.
Description
Adds optional localization to sign-in-or-up flow to render a subtitle if needed.
We always render the subtitle in the dom and hide with CSS when undefined to help with localization key discoverability.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change