Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,localizations,types): Add sign in or up subtitle localizations #4988

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 23, 2025

Description

Adds optional localization to sign-in-or-up flow to render a subtitle if needed.

Default With subtitle
Screenshot 2025-01-23 at 3 07 18 PM Screenshot 2025-01-23 at 3 08 56 PM

We always render the subtitle in the dom and hide with CSS when undefined to help with localization key discoverability.

Screenshot 2025-01-23 at 3 09 28 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 1f2efb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 8:07pm

Comment on lines +443 to +447
sx={{
'&:empty': {
display: 'none',
},
}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the sign in start subtitle is undefined, and we use the empty selector to ensure the element does not take up any space within the dom. This is to enable folks to see that there is a localization option available for subtitle when viewing source in the dom. Then they can add the localization and it will show for them.

@alexcarpenter alexcarpenter marked this pull request as ready for review January 23, 2025 20:10
@alexcarpenter alexcarpenter requested a review from a team January 23, 2025 22:12
@alexcarpenter alexcarpenter changed the title feat(clerk-js,localization): Add sign in or up subtitle localizations feat(clerk-js,localizations): Add sign in or up subtitle localizations Jan 23, 2025
@alexcarpenter alexcarpenter changed the title feat(clerk-js,localizations): Add sign in or up subtitle localizations feat(clerk-js,localizations,types): Add sign in or up subtitle localizations Jan 23, 2025
@alexcarpenter alexcarpenter merged commit 57c983f into main Jan 24, 2025
34 of 35 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sign-in-or-up-subtitle branch January 24, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants