Skip to content

Commit

Permalink
feat(clerk-js,localizations,types): Add sign in or up subtitle locali…
Browse files Browse the repository at this point in the history
…zations (#4988)
  • Loading branch information
alexcarpenter authored Jan 24, 2025
1 parent bd96d6c commit 57c983f
Show file tree
Hide file tree
Showing 45 changed files with 1,530 additions and 131 deletions.
7 changes: 7 additions & 0 deletions .changeset/neat-jokes-remember.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Add `subtitleCombined` localizations to sign-in-or-up flow.
25 changes: 17 additions & 8 deletions packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -429,14 +429,23 @@ export function _SignInStart(): JSX.Element {
<Card.Root>
<Card.Content>
<Header.Root showLogo>
{isCombinedFlow ? (
<Header.Title localizationKey={localizationKeys('signIn.start.titleCombined')} />
) : (
<>
<Header.Title localizationKey={localizationKeys('signIn.start.title')} />
<Header.Subtitle localizationKey={localizationKeys('signIn.start.subtitle')} />
</>
)}
<Header.Title
localizationKey={
isCombinedFlow ? localizationKeys('signIn.start.titleCombined') : localizationKeys('signIn.start.title')
}
/>
<Header.Subtitle
localizationKey={
isCombinedFlow
? localizationKeys('signIn.start.subtitleCombined')
: localizationKeys('signIn.start.subtitle')
}
sx={{
'&:empty': {
display: 'none',
},
}}
/>
</Header.Root>
<Card.Alert>{card.error}</Card.Alert>
{/*TODO: extract main in its own component */}
Expand Down
8 changes: 7 additions & 1 deletion packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,13 @@ function _SignUpStart(): JSX.Element {
isCombinedFlow ? localizationKeys('signUp.start.titleCombined') : localizationKeys('signUp.start.title')
}
/>
<Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')} />
<Header.Subtitle
localizationKey={
isCombinedFlow
? localizationKeys('signUp.start.subtitleCombined')
: localizationKeys('signUp.start.subtitle')
}
/>
</Header.Root>
<Card.Alert>{card.error}</Card.Alert>
<Flex
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/ar-SA.ts
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ export const arSA: LocalizationResource = {
actionText: 'ليس لديك حساب؟',
actionText__join_waitlist: undefined,
subtitle: 'للمتابعة إلى {{applicationName}}',
subtitleCombined: 'للمتابعة إلى {{applicationName}}',
title: 'تسجيل الدخول',
titleCombined: undefined,
},
Expand Down Expand Up @@ -539,6 +540,7 @@ export const arSA: LocalizationResource = {
actionLink__use_phone: undefined,
actionText: 'لديك حساب بالفعل؟',
subtitle: 'للمتابعة إلى {{applicationName}}',
subtitleCombined: undefined,
title: 'أنشاء حساب جديد',
titleCombined: 'أنشاء حساب جديد',
},
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/be-BY.ts
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,7 @@ export const beBY: LocalizationResource = {
actionText: 'Няма ўліковага запісу?',
actionText__join_waitlist: 'Далучыцеся да чакання',
subtitle: 'каб працягнуць працу ў "{{applicationName}}"',
subtitleCombined: undefined,
title: 'Увайсці',
titleCombined: undefined,
},
Expand Down Expand Up @@ -545,6 +546,7 @@ export const beBY: LocalizationResource = {
actionLink__use_phone: 'Увайсці з дапамогай тэлефона',
actionText: 'Ужо ёсць акаўнт?',
subtitle: 'каб працягнуць працу ў "{{applicationName}}"',
subtitleCombined: 'каб працягнуць працу ў "{{applicationName}}"',
title: 'Стварыце Ваш акаўнт',
titleCombined: 'Стварыце Ваш акаўнт',
},
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/bg-BG.ts
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ export const bgBG: LocalizationResource = {
actionText: 'Нямате акаунт?',
actionText__join_waitlist: 'Все още нямате акаунт? Присъединете се към листата за изчакване.',
subtitle: 'Добре дошли обратно! Моля, влезте, за да продължите',
subtitleCombined: undefined,
title: 'Влезте в {{applicationName}}',
titleCombined: undefined,
},
Expand Down Expand Up @@ -540,6 +541,7 @@ export const bgBG: LocalizationResource = {
actionLink__use_phone: 'Използвайте телефон',
actionText: 'Вече имате акаунт?',
subtitle: 'Добре дошли! Моля, попълнете данните, за да започнете.',
subtitleCombined: 'Добре дошли! Моля, попълнете данните, за да започнете.',
title: 'Създайте своя акаунт',
titleCombined: 'Създайте своя акаунт',
},
Expand Down
Loading

0 comments on commit 57c983f

Please sign in to comment.