Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table's width/height should be downcasted to the <figure> #6186

Closed
Reinmar opened this issue Feb 4, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#235
Closed

Table's width/height should be downcasted to the <figure> #6186

Reinmar opened this issue Feb 4, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#235
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 4, 2020

In the image feature we decided to use them on the <figure>. I don't recall why, but there were reasons for that – we started with those styles set on <img> and it was causing problems. It was something about <figure> adding some space around those images (so 100% editable width != 100% image width). Plus, there was some browser bug with inability to use display: table on <figure>. And this style was necessary for the <figure> to take the <img> width (otherwise it's 100% width and that's 💩 ).
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 4, 2020
@Reinmar Reinmar added this to the iteration 29 milestone Feb 4, 2020
@jodator jodator self-assigned this Feb 4, 2020
@jodator jodator mentioned this issue Feb 6, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 11, 2020
@oleq
Merge pull request #235 from ckeditor/i/6186
96dd325 
Internal: The width and the height of a table should be downcasted to the surrounding `<figure>`. Closes ckeditor/ckeditor5#6186.
This was referenced Aug 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

I/6186: downcast height/width to <figure> ckeditor/ckeditor5-table
2 participants
@Reinmar @jodator