Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6186: downcast height/width to <figure> #235

Merged
merged 6 commits into from
Feb 11, 2020
Merged

I/6186: downcast height/width to <figure> #235

merged 6 commits into from
Feb 11, 2020

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Feb 6, 2020

Suggested merge commit message (convention)

Other: The table's width/height should be downcasted to the <figure>. Closes ckeditor/ckeditor5#6186.


Additional information

@coveralls
Copy link

coveralls commented Feb 6, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 1b670ad on i/6186 into ee46155 on master.

Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is OK?

image

Because I think it should be more like this with a little help of .ck-content .table table { height: 100% }

image

@jodator
Copy link
Contributor Author

jodator commented Feb 10, 2020

Are we sure this is OK?

OH it looks bad - I forgot about that. I really don't know how this should behave after all.

It looks like a better suite for height/width is <table> but it gave soem problems in image so addin g .ck-content .table table looks OK.

@oleq
Copy link
Member

oleq commented Feb 11, 2020

Everything else LGTM, so this is the only issue. Some thoughts @Reinmar?

@Reinmar
Copy link
Member

Reinmar commented Feb 11, 2020

Everything else LGTM, so this is the only issue. Some thoughts @Reinmar?

Looks good to me. It feels slightly weird but correct at the same time :D

@oleq oleq merged commit 96dd325 into master Feb 11, 2020
@oleq oleq deleted the i/6186 branch February 11, 2020 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table's width/height should be downcasted to the <figure>
4 participants