Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncate tables in printing mode while using export to pdf #16855

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Aug 5, 2024

Suggested merge commit message (convention)

Fix (table): Larger tables are no longer truncated in print mode. Closes #16856


Additional information

Caused by #6186
Closes: https://github.com/cksource/ckeditor5-commercial/issues/6507
Before:
obraz

After:
obraz

arkflpc
arkflpc previously approved these changes Aug 5, 2024
niegowski
niegowski previously approved these changes Aug 5, 2024
Copy link
Contributor

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works well. I just added suggestions to the comment.

packages/ckeditor5-table/theme/table.css Outdated Show resolved Hide resolved
packages/ckeditor5-table/theme/table.css Outdated Show resolved Hide resolved
@Mati365
Copy link
Member Author

Mati365 commented Aug 6, 2024

@gorzelinski fixed

@Mati365
Copy link
Member Author

Mati365 commented Aug 7, 2024

Passed QA tests.

@Mati365 Mati365 merged commit c0a2a8c into master Aug 7, 2024
8 checks passed
@Mati365 Mati365 deleted the ck/6507 branch August 7, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Larger tables are truncated in print mode
4 participants