Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose toggle buttons in accessibility tree #1403

Closed
Comandeer opened this issue Dec 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#517
Closed

Expose toggle buttons in accessibility tree #1403

Comandeer opened this issue Dec 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#517
Assignees
@msamsel
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 26

Comments

@Comandeer
Copy link
Member

Is this a bug report or feature request? (choose one)

🆕 Feature request

💻 Version of CKEditor

https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html

📋 Steps to reproduce

  1. Click "Bold" button in the toolbar.

✅ Expected result

[aria-pressed] attribute changes value from off to on.

❎ Actual result

[aria-pressed] attribute is added only when the button is in on state.

📃 Other details that might be useful

https://w3c.github.io/aria-practices/examples/button/button.html
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. status:confirmed package:ui labels Dec 11, 2018
@oleq oleq mentioned this issue Dec 11, 2018
Closed
@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. module:ux labels Dec 11, 2018
@Reinmar Reinmar added this to the next milestone Mar 25, 2019
@msamsel msamsel mentioned this issue Jul 5, 2019
Merged
@mlewand mlewand added the domain:accessibility This issue reports an accessibility problem. label Jul 15, 2019
@oleq oleq modified the milestones: nice-to-have, iteration 26 Aug 12, 2019
oleq added a commit to ckeditor/ckeditor5-basic-styles that referenced this issue Aug 12, 2019
@oleq
Merge pull request #95 from ckeditor/t/ckeditor5/1403
b9f5867 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-block-quote that referenced this issue Aug 12, 2019
@oleq
Merge pull request #40 from ckeditor/t/ckeditor5/1403
aa24686 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-heading that referenced this issue Aug 12, 2019
@oleq
Merge pull request #128 from ckeditor/t/ckeditor5/1403
5c41c1a 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-highlight that referenced this issue Aug 12, 2019
@oleq
Merge pull request #43 from ckeditor/t/ckeditor5/1403
1645f26 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-image that referenced this issue Aug 12, 2019
@oleq
Merge pull request #303 from ckeditor/t/ckeditor5/1403
6c74d59 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-link that referenced this issue Aug 12, 2019
@oleq
Merge pull request #246 from ckeditor/t/ckeditor5/1403
b9e31a0 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-list that referenced this issue Aug 12, 2019
@oleq
Merge pull request #135 from ckeditor/t/ckeditor5/1403
bb12325 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-paragraph that referenced this issue Aug 12, 2019
@oleq
Merge pull request #46 from ckeditor/t/ckeditor5/1403
7229cdb 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
oleq added a commit to ckeditor/ckeditor5-alignment that referenced this issue Aug 12, 2019
@oleq
Merge pull request #44 from ckeditor/t/ckeditor5/1403
599ea01 
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Improve the functionality of aria-pressed attribute in button elements ckeditor/ckeditor5-ui
5 participants
@Reinmar @Comandeer @oleq @mlewand @msamsel