Merge pull request #303 from ckeditor/t/ckeditor5/1403

Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
ckeditor · Aug 12, 2019 · 6c74d59 · 6c74d59
2 parents fa6b240 + 221a496
commit 6c74d59
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/imagestyle/imagestyleui.js b/src/imagestyle/imagestyleui.js
@@ -85,7 +85,8 @@ export default class ImageStyleUI extends Plugin {
 			view.set( {
 				label: style.title,
 				icon: style.icon,
-				tooltip: true
+				tooltip: true,
+				isToggleable: true
 			} );
 
 			view.bind( 'isEnabled' ).to( command, 'isEnabled' );

diff --git a/tests/imagestyle/imagestyleui.js b/tests/imagestyle/imagestyleui.js
@@ -56,6 +56,7 @@ describe( 'ImageStyleUI', () => {
 			expect( buttonView ).to.be.instanceOf( ButtonView );
 			expect( buttonView.label ).to.equal( style.title );
 			expect( buttonView.icon ).to.equal( style.icon );
+			expect( buttonView.isToggleable ).to.be.true;
 
 			command.isEnabled = true;
 			expect( buttonView.isEnabled ).to.be.true;