Merge pull request #46 from ckeditor/t/ckeditor5/1403

Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
ckeditor · Aug 12, 2019 · 7229cdb · 7229cdb
2 parents aea609b + 3364aaa
commit 7229cdb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/paragraphbuttonui.js b/src/paragraphbuttonui.js
@@ -40,6 +40,7 @@ export default class ParagraphButtonUI extends Plugin {
 			view.label = t( 'Paragraph' );
 			view.icon = icon;
 			view.tooltip = true;
+			view.isToggleable = true;
 			view.bind( 'isEnabled' ).to( command );
 			view.bind( 'isOn' ).to( command, 'value' );
 

diff --git a/tests/paragraphbuttonui.js b/tests/paragraphbuttonui.js
@@ -50,6 +50,7 @@ describe( 'HeadingButtonUI', () => {
 			expect( paragraphButton.label ).to.equal( 'Paragraph' );
 			expect( paragraphButton.icon ).to.equal( icon );
 			expect( paragraphButton.tooltip ).to.equal( true );
+			expect( paragraphButton.isToggleable ).to.equal( true );
 		} );
 
 		it( 'should bind button to command', () => {