Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAWS: Insert Image (via URL) toolbar dropdown button is not labelled #11896

Closed
Mgsy opened this issue Jun 8, 2022 · 3 comments · Fixed by #11946
Closed

JAWS: Insert Image (via URL) toolbar dropdown button is not labelled #11896

Mgsy opened this issue Jun 8, 2022 · 3 comments · Fixed by #11946
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 8, 2022

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/docs/ckeditor5/latest/features/images/image-upload/images-inserting.html.
  2. Start JAWS, use CTRL+Insert+C to get the available list of dropdowns.

✔️ Expected result

The image toolbar dropdown is labelled properly.

❌ Actual result

The image toolbar dropdown is labelled as "Unlabeled 1".


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. support:2 An issue reported by a commercially licensed client. domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. labels Jun 8, 2022
@mlewand mlewand changed the title JAWS: Insert Image toolbar dropdown is labelled as "Unlabeled 1" JAWS: Insert Image (via URL) toolbar dropdown button is not labelled Jun 15, 2022
@mlewand
Copy link
Contributor

mlewand commented Jun 15, 2022

I checked this issue and it's not that the button as a whole doesn't have a label but only the down arrow part of split button doesn't have a label (I mean it has aria-labelledby but it points to an empty element).

We have two options here:

  1. We can stay with generic "insert image" label (just like it is for the main button).
  2. We can customize label for the dropdown arrow to "Insert image via URL".

I find the latter to be more appropriate here as it better describes the component that will be shown. So let's implement customized label. Good thing is that we'll have the localization ready for it (as it reuses the label from the dropdown).

This issue is closely related to #11833 and should be done after #11833 is merged.

@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 15, 2022
@jswiderski
Copy link

jswiderski commented Jun 21, 2022

This issue has also been reported by one of our clients:

  • aria-labelledby attribute references element that is empty
  • Element's default semantics were not overridden with role="none" or role="presentation"
  • Element has no title attribute (this can probably be omitted when aria-labelledby is not empty)

oleq added a commit that referenced this issue Jul 8, 2022
…not-labelled

Tests (image): Improved `ImageInsertUI` tests, verified the state of the `insertImage` dropdown. (see #11896).
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 8, 2022
@oleq
Copy link
Member

oleq commented Jul 8, 2022

@Reinmar Reinmar added this to the iteration 55 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants