Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tooltip for split button's down arrow #11833

Closed
mlewand opened this issue May 27, 2022 · 1 comment · Fixed by #11859
Closed

Missing tooltip for split button's down arrow #11833

mlewand opened this issue May 27, 2022 · 1 comment · Fixed by #11859
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented May 27, 2022

📝 Provide detailed reproduction steps (if any)

  1. Open document editor example.
  2. Hover the pointer over down arrow of the bulleted list button.

✔️ Expected result

It should show a tooltip like it does for the button's face. It helps to understand the purpose of a button.

❌ Actual result

The tooltip is missing.

📃 Other details

The question is how should the tooltip act on it?

  • Should a separate tooltip (with the same text) be applied to both parts of the split button?
  • Should the tooltip be shared by button's face and the down arrow icon?

Gdocs implement a separate tooltip for both.

  • Browser: Any
  • OS: Any
  • First affected CKEditor version: All

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. package:ui domain:ui/ux This issue reports a problem related to UI or UX. domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. labels May 27, 2022
@mlewand
Copy link
Contributor Author

mlewand commented May 30, 2022

The question is how should the tooltip act on it?

  • Should a separate tooltip (with the same text) be applied to both parts of the split button?
  • Should the tooltip be shared by button's face and the down arrow icon?

I did a quick research on this:

 Hovering/focusing button faceHovering/focusing arrow part
MS Word
GDocs
Other WYSIWYGs

It's safe to say that most commonly we see a separate label for button face and the dropdown arrow. I also feel like it will be the list amount of work for us - so let's have it implemented this way.

@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 31, 2022
oleq added a commit that referenced this issue Jun 21, 2022
…ltip-missing

Fix (ui): The secondary button of the `SplitButtonView` component should display a tooltip while being hovered by the user. Closes #11833.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 21, 2022
@CKEditorBot CKEditorBot added this to the iteration 54 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants