Fix MSBuild workflow

[christianhelle]

This pull request updates the GitHub Actions workflow for the MSBuild process, focusing on improving compatibility and error handling. The most important changes include switching the runner environment, adjusting error tolerance, and cleaning up branch filters.

Workflow environment and configuration updates:

• Changed the workflow runner from ubuntu-latest to windows-latest in the build job to ensure compatibility with MSBuild and related tooling.
• Added continue-on-error: true for the Prepare step, allowing the workflow to proceed even if this step fails, which can help with debugging and non-blocking issues.

Branch filter and trigger cleanup:

• Removed explicit branch filters from both push and pull_request triggers, simplifying workflow activation and ensuring it runs for all branches.

Summary by CodeRabbit

Release Notes

Chores

• Removed branch restrictions from CI triggers so pushes and pull requests run without explicit branch filters.
• Switched continuous integration runner from Linux to Windows to align build environment.

---

Note: This release contains infrastructure updates only. No user-facing features or functionality changes are included.

[coderabbitai]

📝 Walkthrough

Walkthrough

CI workflow .github/workflows/msbuild.yml had branch filters removed from triggers and the runner changed from ubuntu-latest to windows-latest.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration \.github/workflows/msbuild.yml	Removed branch restrictions from push and pull_request triggers; switched runner image from ubuntu-latest to windows-latest.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through YAML, switched the ground beneath,
Branch gates opened, and Windows brings relief,
CI hums along with a cheerful tune —
A tiny change, and pipelines croon.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix MSBuild workflow' accurately summarizes the main change: updating the GitHub Actions MSBuild workflow configuration for improved compatibility and error handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-msbuild-workflow

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This pull request updates the MSBuild workflow to improve Windows compatibility but introduces a critical issue with error handling. The workflow is being migrated from Ubuntu to Windows to properly support the nuget add command which uses Windows-specific path syntax and requires the NuGet CLI tool pre-installed on Windows runners.

Changes:

• Changed runner from ubuntu-latest to windows-latest to support Windows-specific nuget add command with backslash path syntax
• Added continue-on-error: true to the Prepare step (problematic - see comments)
• Removed branch filters from push and pull_request triggers

[Copilot]

Removing branch filters from both push and pull_request triggers is inconsistent with other workflows in the repository. For comparison, build.yml restricts push to 'main' branch and pull_request to all branches, smoke-tests.yml restricts push to 'main', and pr.yml restricts pull_request to 'main'. Without branch filters, this workflow will run on every push and pull request to any branch, which may result in unnecessary CI runs and resource consumption. Consider adding back branch filters consistent with other workflows, e.g., branches: ['main'] for push and branches: ['*'] for pull_request.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/msbuild.yml (1)

25-34: ⚠️ Potential issue | 🟠 Major

continue-on-error: true masks preparation failures, leading to confusing downstream errors.

If any command in the Prepare step fails (restore, build, pack, or nuget add), the workflow will proceed to the Build step without the required package. That Build step will then fail with an unrelated/misleading error, making debugging harder — the opposite of the stated intent.

Consider removing continue-on-error or, if you want visibility into partial failures, splitting the step and only applying it to non-critical commands.

Additionally, line 33 hardcodes the package version (Refitter.MSBuild.1.0.0.nupkg). If the version in the .csproj changes, this will silently break (and continue-on-error will hide it). Using a glob or extracting the version would be more resilient.

Suggested improvements

     - name: 🛠️ Prepare
       working-directory: test/MSBuild
-      continue-on-error: true
       run: |
         dotnet restore ../../src/Refitter.slnx
         dotnet build -c release ../../src/Refitter/Refitter.csproj
         dotnet build -c release ../../src/Refitter.MSBuild/Refitter.MSBuild.csproj
         dotnet pack -c release ../../src/Refitter.MSBuild/Refitter.MSBuild.csproj -o .
-        nuget add .\Refitter.MSBuild.1.0.0.nupkg -source .
+        nuget add (Get-ChildItem .\Refitter.MSBuild.*.nupkg).FullName -source .
         dotnet add package Refitter.MSBuild -s .

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/msbuild.yml (1)

25-33: ⚠️ Potential issue | 🟡 Minor

Missing continue-on-error: true mentioned in the PR description.

The PR description states that continue-on-error: true was added to the Prepare step, but it is not present in the code. If this was intentional, please add it:

Proposed fix

     - name: 🛠️ Prepare
+      continue-on-error: true
       working-directory: test/MSBuild
       run: |