Fix docker smoke tests

[christianhelle]

Summary by CodeRabbit

• Tests
  • Updated smoke test execution to use a more consistent process handling approach.

[coderabbitai]

Warning

Rate limit exceeded

@christianhelle has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 56 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e2c8a3c8-949b-421c-911c-2c76c3ac72a8

📥 Commits

Reviewing files that changed from the base of the PR and between 998c9b1 and 31f438d.

📒 Files selected for processing (1)

• test/smoke-tests.ps1

📝 Walkthrough

Walkthrough

The MultipleInterfacesWithCustomName smoke test now uses the StartRefitter helper function instead of Invoke-Expression, constructing an argument string and capturing the spawned process for consistent Docker and native execution handling across the test suite.

Changes

Cohort / File(s)	Summary
Test Refactoring test/smoke-tests.ps1	Updated MultipleInterfacesWithCustomName smoke test to invoke Refitter via StartRefitter helper instead of Invoke-Expression, capturing process execution and maintaining existing output path verification and cleanup logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• PR #915: Introduced the StartRefitter helper function and reorganized smoke test execution patterns in test/smoke-tests.ps1, providing the foundation for this refactoring to consolidate the MultipleInterfacesWithCustomName test execution.

Poem

🐰 One test now stands with unified grace,
No more Expression sprawl in this place,
The helper brings order, consistent and true,
Docker or native, it knows what to do! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix docker smoke tests' is directly related to the changeset, which modifies the smoke test script to improve Docker command execution handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docker-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 31 minutes and 56 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Updates the smoke test script to run the “Generate-only: MultipleInterfacesWithCustomName” scenario via the shared StartRefitter helper, which correctly supports Docker execution (instead of building a raw command string and Invoke-Expression).

Changes:

• Replace Invoke-Expression command execution with StartRefitter + Wait-Process for the custom-name generate-only test.
• Pass Refitter arguments in a way that works consistently for local and Docker modes.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/smoke-tests.ps1`:
- Around line 477-483: After starting the Refitter process via StartRefitter and
waiting (the $p object), check the process exit code ($p.ExitCode) and throw an
error if it is non-zero before asserting the output file exists; update the
block that uses StartRefitter / $p | Wait-Process / $customNameOutput so it
validates $p.ExitCode and fails the test on non-zero exit codes (e.g., throw
"Generate-only test failed: MultipleInterfacesWithCustomName; exit code
$($p.ExitCode)") prior to the Test-Path check.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9444cbd7-95cf-43b5-be50-68e45b284d88

📥 Commits

Reviewing files that changed from the base of the PR and between f6d53d4 and 998c9b1.

📒 Files selected for processing (1)

• test/smoke-tests.ps1

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud