Skip to content

Fix MSBuild workflow #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianhelle merged 4 commits into from
Feb 14, 2026
Merged

Fix MSBuild workflow #898

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29a88dd
Ignore errors in MSBuild prepare step
christianhelle Feb 13, 2026
84f6a62
Remove branch filter in msbuild workflow
christianhelle Feb 13, 2026
d02dc87
Use windows-latest in msbuild workflow
christianhelle Feb 13, 2026
ba81989
Update msbuild.yml
christianhelle Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/msbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,23 @@ on:
- '!.github/workflows/msbuild.yml'
- '!src/**/*.csproj'
- '!src/**/*.cs'
branches:
- 'main'
pull_request:
paths-ignore:
- '**/*'
- '!.github/workflows/msbuild.yml'
- '!src/**/*.csproj'
- '!src/**/*.cs'
Comment on lines 5 to 16

Copilot AI Feb 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing branch filters from both push and pull_request triggers is inconsistent with other workflows in the repository. For comparison, build.yml restricts push to 'main' branch and pull_request to all branches, smoke-tests.yml restricts push to 'main', and pr.yml restricts pull_request to 'main'. Without branch filters, this workflow will run on every push and pull request to any branch, which may result in unnecessary CI runs and resource consumption. Consider adding back branch filters consistent with other workflows, e.g., branches: ['main'] for push and branches: ['*'] for pull_request.

Copilot uses AI. Check for mistakes.
branches:
- '*'

jobs:
build:
name: 👌 Verify build
runs-on: ubuntu-latest
runs-on: windows-latest
steps:
- name: 🛒 Checkout repository
uses: actions/checkout@v6
- name: 🛠️ Prepare
working-directory: test/MSBuild
continue-on-error: true
Comment thread
christianhelle marked this conversation as resolved.
Outdated
run: |
dotnet restore ../../src/Refitter.slnx
dotnet build -c release ../../src/Refitter/Refitter.csproj
Expand Down