Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3) Create new extension to provide backwards compatibility #4

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Mar 18, 2022

This pull request adds a new extension package that is meant to be used when backwards compatibility is needed for working with older packages that targets old versions of Chocolatey CLI, or if there is a need for packages to be compatibilty with older versions of Chocolatey CLI.
This is intended as superceeding the chocolatey-core.extension package in the terms of the helpers it provides that have been implemented in Chocolatey CLI.

fixes #3

https://app.clickup.com/t/20540031/ENGTASKS-1190

https://app.clickup.com/t/20540031/ENGTASKS-1186

Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one very minor grammatical thing in the package description, but otherwise this all looks good. Thanks for sorting this out!

This commit adds a new compatibility package to
prevent older packages to fail installation if this
package is installed on the user system.
@gep13 gep13 force-pushed the AdmiringWorm/issue3 branch from 6f0223a to 397bc20 Compare March 22, 2022 09:19
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 37760ca into chocolatey-community:master Mar 22, 2022
@gep13
Copy link
Member

gep13 commented Mar 22, 2022

@AdmiringWorm thanks for getting this added!

@AdmiringWorm AdmiringWorm deleted the AdmiringWorm/issue3 branch April 7, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create compatibility package for helpers added or removed in Chocolatey CLI
3 participants