Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#7) Add dependency on compatibility package in core packgage #10

Conversation

AdmiringWorm
Copy link
Member

This pull request updates the chocolatey-core.extension package to provide a dependency on chocolatey-compatibility.extension to ensure that a future change do not break the existing use of the package.

This PR requires the PRs #4 and #9 to be merged first, and this PR to be rebased afterwards.

fixes #7

https://app.clickup.com/t/20540031/ENGTASKS-1204

https://app.clickup.com/t/20540031/ENGTASKS-1186

This commit adds a dependency on chocolatey-compatibilty.extension
package to prevent future breaking in chocolatey-core.extension.
@AdmiringWorm AdmiringWorm force-pushed the 7-core-extension-Add-dependency-on-compatibility-extension branch from 3dfab03 to 66def89 Compare April 11, 2022 08:38
@AdmiringWorm AdmiringWorm marked this pull request as ready for review April 11, 2022 08:39
@AdmiringWorm
Copy link
Member Author

@vexx32 this PR is now ready, once this is merged PR #12 can be rebased and merged as well.

Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for sorting this out! 💖

@vexx32 vexx32 merged commit 7bf91ed into chocolatey-community:master Apr 11, 2022
@AdmiringWorm AdmiringWorm deleted the 7-core-extension-Add-dependency-on-compatibility-extension branch April 11, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(core extension) Add dependency on compatibility extension
2 participants