Issue chipsalliance/UHDM#831: Fix compile issues on MinGW#3401
Merged
alaindargelas merged 2 commits intochipsalliance:masterfrom Dec 23, 2022
Merged
Issue chipsalliance/UHDM#831: Fix compile issues on MinGW#3401alaindargelas merged 2 commits intochipsalliance:masterfrom
alaindargelas merged 2 commits intochipsalliance:masterfrom
Conversation
* Rename "interface" to "interface_inst" to avoid conflicing with system defined class with the same name. * Rename "module" to "module_inst" since the latter is now a C++ reserved word as of C++ 20.
Collaborator
Author
|
Yosys plugin failure is a catch-22 problem. The workflow uses the tip from https://github.com/antmicro/yosys-uhdm-plugin-integration but to update that repo it needs to successfully build using the tip from Surelog repo. I don't think this can be fixed without actually merging this PR and then follow up with fixes to the plugin on a separate PR. The edits to fix the issue in the plugin are trivial changes. Please advise if there's an alternative. |
Collaborator
|
No there is no alternative. @rkapuscik to follow up with a fix |
This was referenced Dec 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue chipsalliance/UHDM#831: Fix compile issues on MinGW
PR Includes chipsalliance/UHDM#845