Skip to content

[TRTLLM-12721][feat] Add disagg transfer state consensus - #2

Closed
chienchunhung wants to merge 1129 commits into
docs-and-plansfrom
codex/disagg-inflight-cancel-impl
Closed

[TRTLLM-12721][feat] Add disagg transfer state consensus#2
chienchunhung wants to merge 1129 commits into
docs-and-plansfrom
codex/disagg-inflight-cancel-impl

Conversation

@chienchunhung

Copy link
Copy Markdown
Owner

Description

Adds a V1 CacheTransceiver request-state consensus step for disaggregated KV transfer terminal transitions.

The implementation records local completed/failed transfer outcomes, packs {request_id, state} entries, gathers them through the existing communication backend, and applies a deterministic consensus result before mutating request state. Context-side consensus uses the existing TP/CP sync group and then the PP group; generation-side consensus uses the existing generation sync group.

This keeps PR#1 scoped to the consensus foundation for safe in-flight cancellation. It does not yet add deadline enforcement, deferred cleanup/quarantine, richer cancellation states, or hard mid-transfer abort semantics; those remain for the follow-up cancellation/lifetime PR.

Notes

  • Failed terminal state wins over completed once all participating ranks report a terminal state.
  • Generation transfer no longer overwrites a receiver-side kDISAGG_TRANS_ERROR with kDISAGG_GENERATION_TRANS_COMPLETE.
  • The existing ready-request-ID collectives are intentionally left in place for this first slice.

Testing

  • pre-commit run --files cpp/include/tensorrt_llm/batch_manager/cacheTransceiver.h cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp
  • git diff --check -- cpp/include/tensorrt_llm/batch_manager/cacheTransceiver.h cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

sara4dev and others added 30 commits May 27, 2026 21:26
…FS compatibility (NVIDIA#11960)

Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Co-authored-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
…y modeling code (NVIDIA#14670)

Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
…nV2 (NVIDIA#14448)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Co-authored-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
…ssor (NVIDIA#14248)

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Co-authored-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
…in /metrics (NVIDIA#14127)

Signed-off-by: Yueh-Ting Chen <yuehtingc@nvidia.com>
Signed-off-by: Yueh-Ting Chen <yueh.ting.chen@gmail.com>
… trigger files (NVIDIA#14087)

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
…ite (NVIDIA#14279)

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
…` import time, re-export `bytes_to_unicod (NVIDIA#14116)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
…A#14688)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
…etadata to pre-NVIDIA#13566 state (NVIDIA#14640)

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
Signed-off-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
Co-authored-by: Gal Hubara-Agam <96368689+galagam@users.noreply.github.com>
Signed-off-by: Pietro Cicotti <5833013+pcicotti@users.noreply.github.com>
…lization (NVIDIA#14648)

Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
Signed-off-by: Tal Cherckez <tcherckez@nvidia.com>
…g to provide local view to Triton kernels for SWA (NVIDIA#13745)

Signed-off-by: Yueh-Ting Chen <yuehtingc@nvidia.com>
…#13963)

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
Signed-off-by: Shreyas Misra <shreyasm@nvidia.com>
Signed-off-by: Shreyas Mista <shreyasm@nvidia.com>
…tention DP batch size in trtllm-bench (NVIDIA#13498)

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…or (NVIDIA#14378)

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
…ck (NVIDIA#14161)

Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
…VIDIA#14594)

Signed-off-by: Aurelien Chartier <2567591+achartier@users.noreply.github.com>
…4587)

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
… `requirements.txt`; mirror in `security_ (NVIDIA#14577)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
…or pre-hopper (NVIDIA#14656)

Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
…merge 40081 (NVIDIA#14653)

Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
…s()` helper in `TestNemotronV2.test_auto_ (NVIDIA#14584)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Co-authored-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
… increase its concurrency to 256 (NVIDIA#14691)

Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
Signed-off-by: Yao Yao <lowsfer@users.noreply.github.com>
greg-kwasniewski1 and others added 25 commits June 8, 2026 09:55
…cher rewrites (NVIDIA#14835)

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Co-authored-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
…A#15089)

Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
…IA#15038)

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
…els (NVIDIA#14851)

Revert c37992c to remove padding.
Added warmup with a grid that should be dense enough to catch almost every possible JIT kernels. Note that this PR only enables warmup and have no shape binning at runtime. I'd like to see how it performs and if it can warmup most kernels then we may not need further works.
Added a message when a possible JIT happened, to give a clear clue why performance dropped.

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
NVIDIA#14898)

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
…15083)

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
…A#14972)

Signed-off-by: jbernloehr <jbernloehr@nvidia.com>
Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
Co-authored-by: jbernloehr <jbernloehr@nvidia.com>
…n trtllm attention (NVIDIA#14911)

Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
Signed-off-by: egeva <19514940+MrGeva@users.noreply.github.com>
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
…VIDIA#14917)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
…cs (NVIDIA#14714)

Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
Signed-off-by: Kanghwan Jang <861393+karljang@users.noreply.github.com>
…rtCachedOperator._apply`), when… (NVIDIA#15020)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
Co-authored-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
…ross-GPU empirical mean) and remove the t (NVIDIA#14799)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
…4956)

Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
…NVIDIA#13978)

Signed-off-by: Yiyun Lu <55233584+luyiyun1021@users.noreply.github.com>
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
…gs as empty PretrainedConfig() then setat (NVIDIA#14399)

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
…ll GPUs (NVIDIA#15112)

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@chienchunhung
chienchunhung force-pushed the codex/disagg-inflight-cancel-impl branch from 30d689f to 5115366 Compare June 9, 2026 05:05
@chienchunhung

Copy link
Copy Markdown
Owner Author

Closing this accidental draft because it targeted docs-and-plans. The implementation branch has been rebased onto upstream/main and will be opened against NVIDIA/TensorRT-LLM:main instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.