[None][doc] Add docs for AutoDeploy transforms - #15122
Conversation
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
|
@CodeRabbit summary |
✅ Action performedSummary regeneration triggered. |
|
Example docs: http://cw-dfw-cs-001-vscode-01:14465/transforms.html |
📝 WalkthroughWalkthroughAdds a Sphinx extension that discovers AutoDeploy transforms from source and YAML configs and generates transform-stage documentation; integrates the extension into Sphinx and adds a landing page plus per-stage RST pages that invoke the new directives. ChangesAutoDeploy Transform Documentation with Sphinx Extension
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
govind-ramnarayan
left a comment
There was a problem hiding this comment.
LGTM, docs look clean. I guess one question is how we will keep this updated - if we add a new transform, will we get a KeyError or something in this trtllm_auto_deploy script? Does it depend on whether it is in an existing stage or in a new stage?
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/_ext/trtllm_auto_deploy.py`:
- Around line 1-2: Replace the current two-line SPDX-only header at the top of
docs/source/_ext/trtllm_auto_deploy.py with the repository's full NVIDIA
copyright/license header block required for Python files (i.e., the standard
multi-line NVIDIA copyright header that includes the company copyright line,
years, and the SPDX-License-Identifier), ensuring the header appears before any
imports or code in the trtllm_auto_deploy module.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 852038e4-5964-44eb-a18b-90b650271ab2
📒 Files selected for processing (18)
.gitignoredocs/source/_ext/trtllm_auto_deploy.pydocs/source/conf.pydocs/source/features/auto_deploy/auto-deploy.mddocs/source/features/auto_deploy/transforms.rstdocs/source/features/auto_deploy/transforms/additional.rstdocs/source/features/auto_deploy/transforms/cache_init.rstdocs/source/features/auto_deploy/transforms/compile.rstdocs/source/features/auto_deploy/transforms/core.rstdocs/source/features/auto_deploy/transforms/export.rstdocs/source/features/auto_deploy/transforms/factory.rstdocs/source/features/auto_deploy/transforms/pattern_matcher.rstdocs/source/features/auto_deploy/transforms/post_export.rstdocs/source/features/auto_deploy/transforms/post_load_fusion.rstdocs/source/features/auto_deploy/transforms/sharding.rstdocs/source/features/auto_deploy/transforms/visualize.rstdocs/source/features/auto_deploy/transforms/weight_load.rstdocs/source/index.rst
For a new transform in an existing configured stage the doc generation is automatic. But a new stage needs a docs page/toctree entry for it to show up as a stage page. |
|
/bot run --stages "A10-Build_Docs" |
|
PR_Github #52885 Bot args parsing error: usage: /bot [-h] |
Hmm, is there any way to write some sort of validation or test that would tell us if a stage was missing in the docs? Not blocking the merging of this PR because I think it will likely be obvious and I don't know if adding a stage will be common, but it could be nice. |
I don't know if there's something that checks for docs against code, but that could be nice. But yeah, doc generation for new transforms to existing stages is automated which is the common case. |
|
/bot run --extra-stage "A10-Build_Docs" |
|
PR_Github #52904 [ run ] triggered by Bot. Commit: |
|
PR_Github #52904 [ run ] completed with state |
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.