Skip to content

[TRTLLMINF-67][infra] use pre-configured idle GPU exemption - #14587

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/idle_gpu
May 28, 2026
Merged

[TRTLLMINF-67][infra] use pre-configured idle GPU exemption#14587
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/idle_gpu

Conversation

@tburt-nv

@tburt-nv tburt-nv commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Use the configuration for the SLURM idle GPU exemption from the shared library.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Refactor
    • Improved idle GPU exemption configuration in test infrastructure by adopting a configuration-based approach, enhancing code maintainability and flexibility.

Review Change Stack

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv
tburt-nv requested a review from a team May 26, 2026 16:16
@tburt-nv
tburt-nv requested a review from a team as a code owner May 26, 2026 16:16
@tburt-nv
tburt-nv requested review from EmmaQiaoCh and mzweilz May 26, 2026 16:16
@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b96b735e-cab3-44e0-a4f7-7b820340ff7f

📥 Commits

Reviewing files that changed from the base of the PR and between 1f8312d and 89312e5.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy

📝 Walkthrough

Walkthrough

The PR refactors idle-GPU exemption logic in the SLURM batch submission function by replacing a hard-coded hostname check with a call to a centralized configuration method, improving maintainability and cluster configuration flexibility.

Changes

SLURM Idle-GPU Exemption

Layer / File(s) Summary
Idle-GPU exemption refactoring
jenkins/L0_Test.groovy
Exemption comment assignment switches from inline hostname conditionals (oci-nrt, oci-hsg, lbd-lax) to SlurmConfig.needsIdleGpuExemption(cluster) check, setting comment from SlurmConfig.IDLE_GPU_EXEMPTION_PAYLOAD when applicable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. It provides only a brief explanation but lacks critical sections: Test Coverage is empty, most PR Checklist items are unchecked, and no detailed rationale is provided. Add information about test coverage safeguarding these changes and complete the PR Checklist by checking items that apply. Provide more details about why this refactoring is needed and any potential impacts.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: refactoring to use pre-configured idle GPU exemption from a shared library instead of hard-coded values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tburt-nv
tburt-nv requested a review from yuanjingx87 May 26, 2026 16:21
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50362 [ run ] triggered by Bot. Commit: 89312e5 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50362 [ run ] completed with state SUCCESS. Commit: 89312e5
/LLM/main/L0_MergeRequest_PR pipeline #39888 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50396 [ run ] triggered by Bot. Commit: 89312e5 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50396 [ run ] completed with state SUCCESS. Commit: 89312e5
/LLM/main/L0_MergeRequest_PR pipeline #39920 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50634 [ run ] triggered by Bot. Commit: 89312e5 Link to invocation

Comment thread jenkins/L0_Test.groovy
@tburt-nv
tburt-nv enabled auto-merge (squash) May 28, 2026 00:31
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50634 [ run ] completed with state SUCCESS. Commit: 89312e5
/LLM/main/L0_MergeRequest_PR pipeline #40126 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only failure has a fix in progress #14536"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50831 [ skip ] triggered by Bot. Commit: 89312e5 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50831 [ skip ] completed with state SUCCESS. Commit: 89312e5
Skipping testing for commit 89312e5

Link to invocation

@tburt-nv
tburt-nv merged commit 776bebc into NVIDIA:main May 28, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants