[diegosouzapw]

Closes #3494
Closes #3495

Hard Rule #12: these built error response bodies from a raw err.message/error.message, bypassing the canonical sanitizer (risk of leaking internal/upstream detail).

#3494 — 5 web executors: adapta-web, deepseek-web, perplexity-web (both TLS + connection branches), qoder, veoaifree-web.
#3495 — embeddings.ts + search.ts (two sites).

Each now imports sanitizeErrorMessage and wraps the response-body message (internal log.*/saveCallLog audit lines left as-is). Dropped all 7 from KNOWN_MISSING_ERROR_HELPER in check-error-helper.mjs.

Regression guard: node scripts/check/check-error-helper.mjs → OK, 0 violations with the 7 files unfrozen (the gate fails if any still forwards a raw message). typecheck + docs-sync green.

[gemini-code-assist]

Code Review

This pull request improves security by routing raw error messages through sanitizeErrorMessage() across several web executors (adapta-web, deepseek-web, perplexity-web, qoder, veoaifree-web) and handlers (embeddings, search) to prevent internal detail leakage. It also updates the check script to reflect these additions. The review feedback correctly identifies multiple locations where err.message or error.message is accessed directly without a type guard, which could cause runtime crashes if the thrown object is not an instance of Error. The reviewer provides actionable suggestions to safely check the error type before accessing its message.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

In the isTlsUnavail branch, casting err as Error and accessing .message directly is unsafe if err is not an instance of Error (or is null/undefined). This could throw a TypeError and crash the handler. It is safer to use the same fallback check as the second branch.

Suggested change

	message: isTlsUnavail
	? `Perplexity TLS client unavailable: ${(err as Error).message}`
	: `Perplexity connection failed: ${err instanceof Error ? err.message : String(err)}`,
	? `Perplexity TLS client unavailable: ${sanitizeErrorMessage((err as Error).message)}`
	: `Perplexity connection failed: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`,
	message: isTlsUnavail
	? `Perplexity TLS client unavailable: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`
	: `Perplexity connection failed: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`,

[gemini-code-assist]

Accessing error.message directly is unsafe if error is not an instance of Error (e.g., if it is null, undefined, or a string). Consider using a type guard or fallback to prevent potential runtime exceptions.

Suggested change

	message: `Qoder fetch error: ${sanitizeErrorMessage(error.message)}`,
	message: `Qoder fetch error: ${sanitizeErrorMessage(error instanceof Error ? error.message : String(error))}`,

[gemini-code-assist]

Accessing err.message directly is unsafe if err is not an instance of Error. Consider using a type guard or fallback to prevent potential runtime exceptions.

Suggested change

	error: `Embedding provider error: ${sanitizeErrorMessage(err.message)}`,
	error: `Embedding provider error: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`,

[gemini-code-assist]

Accessing err.message directly is unsafe if err is not an instance of Error. Consider using a type guard or fallback to prevent potential runtime exceptions.

Suggested change

	error: `Search provider ${isTimeout ? "timeout" : "error"}: ${sanitizeErrorMessage(err.message)}`,
	error: `Search provider ${isTimeout ? "timeout" : "error"}: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`,

[gemini-code-assist]

Accessing err.message directly is unsafe if err is not an instance of Error. Consider using a type guard or fallback to prevent potential runtime exceptions.

Suggested change

	error: `Search provider ${isTimeout ? "timeout" : "error"}: ${sanitizeErrorMessage(err.message)}`,
	error: `Search provider ${isTimeout ? "timeout" : "error"}: ${sanitizeErrorMessage(err instanceof Error ? err.message : String(err))}`,