[diegosouzapw]

Closes #3558

Problem: PublicAI's 3 models were tagged freeType:"keyless" (in the RECURRING set), so they surfaced as keyless-free and could be picked into the no-auth pool and dispatched with no Authorization header. But the registry requires a key (authType:"apikey") and freeTierCatalog.ts already excluded publicai — an internal inconsistency that both misled users ("free") and produced upstream rejections.

Fix: the 3 PublicAI entries move to freeType:"one-time-initial" (signup credit then paid, like nscale/qoder), and providers.ts publicai.hasFree → false with an accurate note.

Validation: this is an internal catalog/registry consistency correction (the registry authType + the freeTierCatalog exclusion already establish publicai is key-required). Test (Rule #18): tests/unit/publicai-not-keyless-3558.test.ts — RED before the fix; asserts no publicai keyless entry remains and all are one-time-initial. free-model-catalog + free-budget-card suites still green.

Source: discussion #3548 (reporter @ColaIan).

[gemini-code-assist]

Code Review

This pull request corrects the classification of PublicAI models, which were previously miscatalogued as keyless/free, by updating their freeType to one-time-initial and setting hasFree to false in the provider registry. A new unit test was also added to prevent regressions. Feedback on these changes suggests removing the PublicAI entries from the free model catalog entirely to avoid dead entries, and refactoring the new unit test to use Vitest instead of Node's built-in test runner to maintain consistency with the repository's testing framework.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Since publicai is now marked as hasFree: false in providers.ts and has both monthlyTokens: 0 and creditTokens: 0, these models are no longer part of any active free tier or budget. Keeping them in FREE_MODEL_BUDGETS (which is specifically for free model budgets) is inconsistent and could lead to dead entries or unexpected behavior in the UI/routing logic.

Consider removing these three publicai entries from FREE_MODEL_BUDGETS entirely instead of reclassifying them to one-time-initial with zero tokens.

[gemini-code-assist]

Since the project uses Vitest (as indicated by vitest.config.ts in the root), it is highly recommended to use vitest for writing unit tests instead of Node's built-in node:test and node:assert. This ensures consistent test execution, reporting, and coverage analysis across the codebase.

If you decide to remove the publicai entries from FREE_MODEL_BUDGETS entirely (as suggested in the other comment), this test can be simplified to assert that FREE_MODEL_BUDGETS contains zero entries for publicai. Below is the suggested implementation using Vitest.

Suggested change

	import test from "node:test";
	import assert from "node:assert/strict";
	import { FREE_MODEL_BUDGETS } from "../../open-sse/config/freeModelCatalog.data.ts";
	// Regression for #3558: PublicAI was catalogued with freeType:"keyless" (in the RECURRING set,
	// so it surfaced as keyless-free and could be picked into the no-auth pool with no Authorization
	// header). But the provider registry requires a key (authType:"apikey"), and freeTierCatalog.ts
	// already excludes publicai from recurring free budgets — an internal inconsistency. PublicAI
	// grants a one-time signup credit then bills, so it must NOT be "keyless".
	test("#3558 PublicAI has no freeType:keyless catalog entries", () => {
	const keyless = FREE_MODEL_BUDGETS.filter(
	(b) => b.provider === "publicai" && b.freeType === "keyless"
	);
	assert.equal(keyless.length, 0, `publicai must not be keyless; found ${keyless.length}`);
	});
	test("#3558 PublicAI catalog entries are classified one-time-initial", () => {
	const entries = FREE_MODEL_BUDGETS.filter((b) => b.provider === "publicai");
	assert.ok(entries.length > 0, "publicai still has catalog entries");
	for (const e of entries) {
	assert.equal(e.freeType, "one-time-initial", `${e.modelId} should be one-time-initial`);
	}
	});
	import { test, expect } from "vitest";
	import { FREE_MODEL_BUDGETS } from "../../open-sse/config/freeModelCatalog.data.ts";
	// Regression for #3558: PublicAI requires an API key and is not part of the free model catalog.
	test("#3558 PublicAI has no entries in the free model catalog", () => {
	const entries = FREE_MODEL_BUDGETS.filter((b) => b.provider === "publicai");
	expect(entries.length).toBe(0);
	});

References

1. The repository uses Vitest as its official testing framework (as indicated by vitest.config.ts and Vitest files references in the style guide). Unit tests should use Vitest APIs rather than node:test. ^(link)

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

This PR correctly addresses #3558 by fixing an internal inconsistency where PublicAI was miscatalogued as keyless/free when it actually requires an API key. The changes are:

1. open-sse/config/freeModelCatalog.data.ts - Changes freeType from "keyless" to "one-time-initial" for the 3 PublicAI models (lines 410-412 new). This prevents them from being selected in the no-auth pool.
2. src/shared/constants/providers.ts - Changes hasFree: true to hasFree: false with updated comment explaining PublicAI requires an API key and has one-time signup credit (lines 1437-1440 new).
3. tests/unit/publicai-not-keyless-3558.test.ts - Adds regression tests verifying PublicAI models are classified as one-time-initial and not keyless.
4. CHANGELOG.md - Documents the fix.

All changes are consistent with the provider registry which already specifies authType: "apikey" for PublicAI.

Files Reviewed (4 files)

• CHANGELOG.md - 1 issue
• open-sse/config/freeModelCatalog.data.ts - 0 issues (existing inline comment noted)
• src/shared/constants/providers.ts - 0 issues (existing inline comment noted)
• tests/unit/publicai-not-keyless-3558.test.ts - 0 issues (existing inline comment noted)

---

_{Reviewed by laguna-m.1-20260312:free · 1,082,400 tokens}