Repository navigation
merge queue: checking #19137 on release/v3.8.53 (8134d2f), stacked on 4 pull requests ahead - #19172
Closed
mergify[bot] wants to merge 26 commits into
Closed
mergify[bot] wants to merge 26 commits into
mergify[bot] wants to merge 26 commits into
Conversation
Add a thin FileInput/FileDropZone adapter (src/shared/components/FileInput.tsx) over @omniroute/ui-kit/file-input that fills the kit's English text defaults (choose, empty, selected-count, drop labels) from new common.* keys, and use it where the dashboard carried a raw file input whose kit-exception said the kit had none: - batch UploadFileModal and wizard InputStep drop zones -> FileDropZone (same accept, 512 MB limit, error banner, single-file pick, disabled while reading; InputStep keeps its soft extension check) - ProviderTransferPanel, RtkTomlImportCard, the Omni Skills install modal -> FileInput (visible picker with a status line) EvalsTab, ComboHeaderActions and MemoriesTab keep their hidden picker behind a toolbar button (the pick imports at once, and a status line would break the action row); their kit-exception now states that reason. Refs #19066
Toggle maps size xs/sm to the kit Switch size="sm" and md/lg to the default, and CatalogKeyAccessButton passes size="sm" to its kit Switch. The kit (0.0.89) already stretches the native input over the control for every size and dims a bare disabled switch, so the OmniRoute .ci-switch--compact rules, the "Kit Switch hit target" block in globals.css and the opacity-50 workarounds go. The kit sm track is 33x18px (the old compact one was 36x20px). Refs #19066
The six common.fileInput*/fileDrop* keys the FileInput adapter added reached only en, pt-BR and vi, so the new-key coverage and key completeness gates (i18n UI Coverage) would fail. Translated with scripts/i18n/translate-new-keys.sh for the other 64 locales and inserted next to the English position, without the key reordering a full sync applies; no other key changes. Refs #19066
Provider dispatch let fetch follow redirects automatically. The SSRF string guard and the connect-time DNS-rebinding guard saw only the first URL, so a provider host (or a base URL an actor controls) could answer with a 3xx to loopback or cloud metadata. On 307/308 the POST body and the provider API key went to that target too. dispatchGuarded now dispatches with redirect "manual" and follows up to 5 hops itself. Each Location is resolved against the current URL and passes the same string guard and connect-time guard as the first request. Credential headers are dropped when the origin changes. Method rules follow the Fetch standard. Callers that pin a redirect mode (strict model validation uses "error") keep it. The wreq TLS transport now honours a caller redirect mode instead of always following.
assertDispatchUrlAllowed returned early for local and self-hosted providers, before any check. The guard policy says cloud metadata stays blocked in every mode, and the webhook guard does block it. A local provider with a base URL on the link-local metadata address therefore sent its POST and stored key there. Exempt providers now still run the non-metadata check. Loopback and LAN base URLs stay allowed for them.
…i-kit-adopt-inputs-1105
…i-kit-adopt-inputs-1105
…n, Badge tones and NativeSelect Removes the local .ci-button--warning, .ci-badge[data-tone] and .ci-select-native rules from globals.css. Native Select callers keep their size through nativeSize, and the Pool schedule rows move to the kit xs height. Refs #19066
…i-kit-adopt-inputs-1105
…5' into chore/ui-kit-0-0-95-1105 # Conflicts: # src/app/globals.css
…it-0-0-95-1105 # Conflicts: # src/app/globals.css
GitHub fills started_at while a job still waits in the queue, so an amd64 job stuck for 13 h read as 1,596 spent minutes.
At 40 ms a loaded runner misses the budget before the job starts and the limiter correctly times it out, which dequeued an unrelated PR.
Two days of reviews: 18 findings on packages/ui-kit, which cannot be fixed here, and 7 file-limit failures, all on do-not-merge train PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch abounding-brillat-jp342m of the
releasequeue, to test #19137 before it merges intorelease/v3.8.53.What this draft tests
Mergify checks that #19137 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:
release/v3.8.53at8134d2f578f5f0The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.
✨ Where it stands: closed
Pull request #19137 has been dequeued.
Queue conditions are not satisfied:
Follow the
releasequeue in the dashboardWhat happens next
Tip
A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the 4 pull requests ahead, so a failure here can come from them as much as from #19137. See only this batch's changes.
Queued ahead of this batch
These pull requests entered the queue before this batch and are not part of it.
Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
releasefor merge#check-pending=0check-success=Gate / CIcheck-success=Gate / Qualitycheck-success=Merge integrity (changelog + generated skills)#check-success>=1github-review-approved[🛡 GitHub repository ruleset ruleRequire PR on default branch]#check-failure=0#check-failure=1check-failure=Build (advisory)Required conditions to stay in the queue
label=queue-conflict-draft-head~=^fix/relay-integration-candidate--label=integration-reviewedbase~=^release/v\d+\.\d+\.\d+$github-review-approved[🛡 GitHub repository ruleset ruleRequire PR on default branch]