Repository navigation
fix(sse): preserve tool output in safe compression plans - #18818
Merged
diegosouzapw merged 5 commits intoNov 4, 2026
Merged
diegosouzapw merged 5 commits into
diegosouzapw merged 5 commits into
Conversation
stanleytejakusuma
marked this pull request as ready for review
November 3, 2026 05:24
# Conflicts: # open-sse/services/compression/lossyRequestPolicy.ts # tests/unit/chatcore-compression-combo-predicates.test.ts # tests/unit/compression/active-combo-dispatch.test.ts # tests/unit/compression/active-combo-integration.test.ts # tests/unit/compression/compression-header-dispatch.test.ts # tests/unit/compression/derive-effective-preview-plan.test.ts # tests/unit/compression/derived-pipeline-integration.test.ts # tests/unit/compression/lossy-request-policy.test.ts
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This was referenced Nov 4, 2026
diegosouzapw
merged commit Nov 4, 2026
222e3f9
into
cheaper-inference:release/v3.8.53
13 of 34 checks passed
This was referenced Nov 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Default compression could silently clip historical tool results to about 2 KB even when a request had not opted into lossy compression. Disabling tool-result clipping alone was insufficient: Lite still removed trailing spaces and folded blank lines. The Responses WebSocket and offline eval callers also discarded the selected request-scoped pipeline and could execute the stored pipeline instead.
Fix
compressToolResultsis false; leave non-tool processing, caps, dependencies and session deduplication unchanged.Regression evidence and fresh verification
Actual failing-then-passing tests were captured during implementation: a 10,800-byte historical result was clipped to 1,937 bytes; after the clipping fix, a whitespace-sensitive 10,800-byte result still became 10,791 bytes. The whitespace regression set failed 74 of 79 tests before its fix and passed the same 79 afterward. Coverage includes 10,800 / 16,000 / 100,000-byte unique results, Chat/Responses layouts, sync/async engines, opt-in controls and unchanged stored settings.
Fresh results after rebasing onto
493101c3f1c82091e316ac3162a8511e17f43f7c:Commands used for focused and static verification:
The standalone complexity command still exits 1 for two existing cyclomatic violations; the measured finding count decreases from 3 to 2. The same config was also run against each base blob via
--stdin --stdin-filenameto compare identical paths without changing the checkout. Vitest ran with a separate temporaryDATA_DIRand plugin directory, with SQLite automatic backups disabled.Normal commit hooks ran without bypass or stashing. The private-reference UI-kit snapshot gate self-skipped in this fork environment. At initial draft publication, the full native unit suite, production build and coverage gate had not been rerun locally. Ready-for-review CI has since passed on
383217d4bd179f9cc676be3b2099a7f1c6f5cece(2026-11-03): all 8 unit-test shards, Vitest, Build, Coverage, Quality Ratchet, Lint, Security Tests and both aggregate gates.The earlier draft-triggered aggregate failures are superseded by those successful runs. Unselected package-artifact and live E2E jobs remain skipped, not certified passes.
Known base status
The base tracker reports a package-artifact gate timeout and a skipped tarball boot-smoke. This PR does not attempt to fix those base failures.