Repository navigation
fix(routing): share provider alias pools with combo discovery - #15927
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
# Conflicts: # stryker.conf.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combo discovery queried connections by a single provider ID even though direct credential selection already expands aliases. An
agyaccount could therefore serve directantigravityrequests but disappear from auto scoring, quota expansion, tags and affinity; the same mismatch affectedopencode/opencode-zen.Extract the existing provider search-pool resolver unchanged and share it with the combo consumers. The pooled reader reuses the existing DB cache and deduplicates connection IDs. Quota expansion checks membership in each target's resolved pool, preserving rejection of foreign pins even when that provider is another target in the combo. Existing API-key/step allowlists, tags, forced pins and unambiguous custom-node ownership checks remain in place.
Validation:
97da13f773625a8e0eb25559d3d70fbb2c7113d0.useModelImportHandlersTS2339 (17)/TS2345 (1) andengineConfigSaveTS2345 (1). No baseline changes; release validation debt remains separate under 🔴 Release branch not green: release/v3.8.52 #15306.#13177 remains the separate provider-consolidation proposal awaiting a maintainer decision. This implements the independent pool correction requested in the #12844 maintainer comment, including OpenCode, without migrating or consolidating providers.
Closes #12844
Evidence
Mutation-runner follow-up:
node scripts/check/check-mutation-test-coverage.mjs --strictreproduced the missing test registration (exit 1) before this update and passed (exit 0) after adding the existing regression file tostryker.conf.jsontap.testFiles.npm run check:test-discoveryalso passed. This follow-up changes only test selection; the previously reported production/test executions remain unchanged. No mutation-score run or globally green CI is claimed.