Repository navigation
fix(release): drain four v3.8.52 base-reds left by #15891, #15927 and #15968 - #16107
Merged
Merged
Conversation
…15968 - hard-session-lease inventory: #15891 added a rateLimitedUntil state re-read in tokenHealthCheck.ts (class C, 3 -> 4); #15927 moved providerWildcard.ts's connection read behind getCachedProviderPoolConnections() (read cache, 1 -> 0). - agnes-cn-provider / flagship-0day-discovery: #15927 moved PROVIDER_SEARCH_PAIRS from src/sse/services/auth.ts to open-sse/services/providerConnectionPool.ts; point the source-shape guards at the new home (pair list unchanged). - provider translate-path golden: #15968 intentionally dropped claude-code-20250219 from the Anthropic API-key beta defaults; regenerate.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drains four reds on the
release/v3.8.52tip (4a2269b). Each one reproduced alone on the pure tip. All four are stale test fixtures left behind by merged PRs; none is a production defect. Test-only change, no production code touched.1.
hard-session-lease-bypass-inventory.test.ts: inventory driftsrc/lib/tokenHealthCheck.ts3 -> 4, caused by fix(oauth): preserve active cooldown diagnostics on token refresh #15891. The newgetRefreshRecoveryUpdate()callsgetProviderConnectionById()after a successful refresh. It only readsrateLimitedUntil, so an active cooldown's diagnostics are not wiped. That is a state read with no connection selection, credential use or dispatch, so it is class C, the same as the existing fix(oauth): skip a second POST of a consumed Claude refresh token #13874 re-read in the same file.open-sse/services/combo/providerWildcard.ts1 -> 0, caused by fix(routing): share provider alias pools with combo discovery #15927. The Alibaba free-tier drained-model filter used to callgetProviderConnections()directly. It now goes throughgetCachedProviderPoolConnections()inopen-sse/services/providerConnectionPool.ts, which callsgetCachedProviderConnections(). The underlyinggetProviderConnectionscall is already counted undersrc/lib/db/readCache.ts, so nothing went unclassified. I also removed the entry from the class-B list. Neither change is a lease bypass.deepEqualfailure on those two keys. Green: 3/3 pass.2.
provider-translate-path-golden.test.ts: snapshot driftanthropicprovider'sAnthropic-Betaheader (apiKey, nonStream and oauth variants). It losesclaude-code-20250219.ANTHROPIC_BETA_API_KEYinopen-sse/config/anthropicHeaders.tson purpose and pinned it inanthropic-api-key-beta-15942.test.ts. The change is intended, so I regenerated the snapshot withUPDATE_GOLDEN=1. This does not depend on the open feat(jev): opt-in decision layer (System One / bring-your-own classifier) #15641.GoldenMismatchError provider/translate-path. Green: 3/3 pass.3.
agnes-cn-provider.test.ts(+ the same red inflagship-0day-discovery.test.tstest 7)PROVIDER_SEARCH_PAIRS declaration missing, not a wrong pairing. fix(routing): share provider alias pools with combo discovery #15927 movedPROVIDER_SEARCH_PAIRSandgetProviderSearchPoolout ofsrc/sse/services/auth.tsintoopen-sse/services/providerConnectionPool.ts. The pair list moved byte-for-byte and still has no agnes, agnes-cn or xai entry.check-test-maskingvs base reports no weakening.declaration missing. Green: agnes-cn 16/16 and flagship-0day 10/10 pass. The flagship red was not in the dispatch list but had the same root cause.Validation
typecheck:coreOK.check-api-typecheckOK (within baseline). eslint with suppressions on the changed files OK.check-file-size,check-test-masking(vs base),check-changelog-integrityandcheck-test-discoveryOK. The pre-commit hooks passed.flagship-0day-discovery.test.tsalso picked up Prettier reformatting of two pre-existing lines.